Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid - Android - Reports - App crashes when opening reports section after tracking distance expense #55459

Closed
1 of 8 tasks
IuliiaHerets opened this issue Jan 19, 2025 · 38 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5476052&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers): ibellicotest+191@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Money Requests

Action Performed:

  1. Open the Expensify app.
  2. Tap on "Reports" on the bottom of the screen.
  3. Tap on the FAB and select "Create Expense"
  4. Tap on "Distance" and add valid waypoints.
  5. Tap on "Next"
  6. Tap on "Just track it (Don´t submit it).
  7. Tap on "Create Expense"
  8. Once redirected to "Reports" again, wait for the expense to appear on the list.
  9. Navigate to Self DM.
  10. On the options on the created expense, select "Share it with my accountant" and submit the expense to any workspace.
  11. Close the "Invite new members modal"
  12. Tap on the arrow on the top left corner to return to inbox.
  13. Tap on "Reports" on the bottom of the screen.
  14. Check if you are able to return to that section and that the created expense is correctly displayed.

Expected Result:

After tracking a distance expense while in "Reports" section and submitting it to a workspace, the user should be able to reopen the "Reports" section and the created expense should be correctly displayed on the list.

Actual Result:

After tracking a distance expense while in "Reports" section and submitting it to a workspace, the user is unable to reopen the "Reports" section again. App crashes everytime that the section is opened.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/22dd5621-85a6-48fd-80b9-754c39e142f6
Bug6717840_1737236953415!log.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021881786394640245497
  • Upwork Job ID: 1881786394640245497
  • Last Price Increase: 2025-02-11
Issue OwnerCurrent Issue Owner: @luacmartins
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 19, 2025
Copy link

melvin-bot bot commented Jan 19, 2025

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MitchExpensify MitchExpensify added the External Added to denote the issue can be worked on by a contributor label Jan 21, 2025
@melvin-bot melvin-bot bot changed the title Hybrid - Android - Reports - App crashes when opening reports section after tracking distance expense [$250] Hybrid - Android - Reports - App crashes when opening reports section after tracking distance expense Jan 21, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021881786394640245497

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 21, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

@MitchExpensify
Copy link
Contributor

Seeing as this is a bottom-up flow, I think #convert makes most sense

@waynebloom
Copy link

Hello, brand new contributor here 👋

I would like to investigate this issue in order to submit a proposal, but as a brand new contributor I do not have access to the Hybrid project. I didn't see details in the contributor guide for how to request access, so I am unsure if this is the proper place to do that.

Copy link

melvin-bot bot commented Jan 23, 2025

📣 @waynebloom! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@waynebloom
Copy link

Contributor details
Your Expensify account email: wayne.bloom224@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0145e456ff343aea31

Copy link

melvin-bot bot commented Jan 23, 2025

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Copy link

melvin-bot bot commented Jan 27, 2025

@MitchExpensify, @dominictb Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jan 27, 2025
@MitchExpensify
Copy link
Contributor

@waynebloom I'm not sure what you mean by "I do not have access to the Hybrid project", can you please clarify?

Copy link

melvin-bot bot commented Jan 28, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 29, 2025

@MitchExpensify, @dominictb Still overdue 6 days?! Let's take care of this!

@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@pac-guerreiro
Copy link
Contributor

According to the logs provides, the cause for the crash seems to be this:

01-18 18:32:09.426 24917 25832 E unknown:ReactNative: TypeError: undefined is not a function
01-18 18:32:09.426 24917 25832 E unknown:ReactNative: 
01-18 18:32:09.426 24917 25832 E unknown:ReactNative: This error is located at:
01-18 18:32:09.426 24917 25832 E unknown:ReactNative:     in ReceiptCell
01-18 18:32:09.426 24917 25832 E unknown:ReactNative:     in RCTView
01-18 18:32:09.426 24917 25832 E unknown:ReactNative:     in Unknown
01-18 18:32:09.426 24917 25832 E unknown:ReactNative:     in RCTView
01-18 18:32:09.426 24917 25832 E unknown:ReactNative:     in Unknown
01-18 18:32:09.426 24917 25832 E unknown:ReactNative:     in TransactionListItemRow

I'll investigate what is causing this and let you know!

Copy link

melvin-bot bot commented Jan 31, 2025

@MitchExpensify, @dominictb Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@pac-guerreiro
Copy link
Contributor

Still working on this! Yesterday I had to jump into an infinite re-render issue that was critical. Today I'll focus on this 🫡

Copy link

melvin-bot bot commented Feb 2, 2025

@MitchExpensify @dominictb this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@pac-guerreiro
Copy link
Contributor

Last friday I found out that the problem is caused by receipt.source being a number instead of a string, as expected.

Today, I saw that issue lies on the snapshot_ collection, because on the transaction object we have the right string.

This is the transaction object in snapshot collection:

Image

This is the transaction object in transactions collection:

Image

I need help from someone with access to the backend to confirm if the API is sending the correct data

@MitchExpensify
Copy link
Contributor

@pac-guerreiro Have you asked someone for help with the backend already?

@pac-guerreiro
Copy link
Contributor

I asked for help on expensify-callstack channel, but no one specifically

@MitchExpensify
Copy link
Contributor

Ok let me know if nobody jumps in to help and I can help recruit someone

Copy link

melvin-bot bot commented Feb 4, 2025

@MitchExpensify, @dominictb 12 days overdue now... This issue's end is nigh!

Copy link

melvin-bot bot commented Feb 4, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@luacmartins luacmartins self-assigned this Feb 4, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 4, 2025
@dominictb
Copy link
Contributor

Initial investigation indicates that this is related to BE. We need an internal engineer to take a look at #55459 (comment).

🎀👀🎀

Copy link

melvin-bot bot commented Feb 5, 2025

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

@luacmartins, @MitchExpensify, @dominictb Eep! 4 days overdue now. Issues have feelings too...

@MitchExpensify
Copy link
Contributor

@pac-guerreiro you have help here from @luacmartins , what do we need to do to push this forward?

@pac-guerreiro
Copy link
Contributor

@MitchExpensify @luacmartins I need to understand if the problem lies on the BE or the FE. For that I need confirmation from BE side that they're sending the proper data. If not, I'll need to check what's causing the wrong data on the FE side 😄

@luacmartins
Copy link
Contributor

Looking at this now

@melvin-bot melvin-bot bot removed the Overdue label Feb 10, 2025
@luacmartins
Copy link
Contributor

Hmm Distance requests are not working for me in dev. Asked about it here

Copy link

melvin-bot bot commented Feb 11, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@pac-guerreiro
Copy link
Contributor

@luacmartins is there anything I can help you with?

@luacmartins
Copy link
Contributor

We're discussing it here https://expensify.slack.com/archives/C01GTK53T8Q/p1739313474830049

@melvin-bot melvin-bot bot added the Overdue label Feb 14, 2025
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Feb 16, 2025

@luacmartins @MitchExpensify @dominictb this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Copy link

melvin-bot bot commented Feb 17, 2025

@luacmartins, @MitchExpensify, @dominictb Huh... This is 4 days overdue. Who can take care of this?

@MitchExpensify
Copy link
Contributor

Not overdue, Melvin. The issue is not reproducible and we're discussing here: https://expensify.slack.com/archives/C01GTK53T8Q/p1739313474830049

@pac-guerreiro
Copy link
Contributor

@MitchExpensify @luacmartins @dominictb

Issue is no longer reproducible from my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Development

No branches or pull requests

7 participants