Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$50] iOS mWeb Safari - Expense - User has to tap Save button twice to save value #55275

Closed
1 of 8 tasks
vincdargento opened this issue Jan 15, 2025 · 18 comments
Closed
1 of 8 tasks

[$50] iOS mWeb Safari - Expense - User has to tap Save button twice to save value #55275

vincdargento opened this issue Jan 15, 2025 · 18 comments
Assignees
@madmax330 @muttmuure @shubham1206agra @dukenv0307
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@vincdargento
Copy link

vincdargento commented Jan 15, 2025 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.86-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): iPhone 15 Pro Max / iOS 18.2
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Tap + > Submit expense > Manual.
  4. Enter amount > Next.
  5. Tap Merchant.
  6. Tap on the field.
  7. Enter anything.
  8. Tap Save button.
  9. Tap Save button again.

Expected Result:

Tapping Save button once will save the value.

Actual Result:

Tapping Save button once closes the keyboard.
Tapping Save button again only saves the value.

The same issue also happens in similar pages with input field and green button like during bank account set up.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021879556565224182727
  • Upwork Job ID: 1879556565224182727
  • Last Price Increase: 2025-01-15
  • Automatic offers:
    • shubham1206agra | Contributor | 105739091
Issue OwnerCurrent Issue Owner: @dukenv0307
@vincdargento vincdargento added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 15, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@vincdargento
Copy link
Author

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@github-actions github-actions bot mentioned this issue Jan 15, 2025
Closed
31 tasks
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 15, 2025
@melvin-bot melvin-bot bot changed the title iOS mWeb Safari - Expense - User has to tap Save button twice to save value [$250] iOS mWeb Safari - Expense - User has to tap Save button twice to save value Jan 15, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021879556565224182727

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 15, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@mountiny mountiny changed the title [$250] iOS mWeb Safari - Expense - User has to tap Save button twice to save value [$50] iOS mWeb Safari - Expense - User has to tap Save button twice to save value Jan 15, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

Upwork job price has been updated to $50

@mountiny
Copy link
Contributor

mountiny commented Jan 15, 2025 •
edited
Loading

$50 if you can identify the offending PR and confirm that revert fixes this

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Jan 15, 2025 •
edited
Loading

@mountiny I suspect #54736. Testing the revert #55296

@melvin-bot melvin-bot bot mentioned this issue Jan 15, 2025
Closed
8 tasks
@shubham1206agra
Copy link
Contributor

@mountiny Confirming fix on revert

Screen.Recording.2025-01-15.at.11.14.02.PM.mov

@shubham1206agra shubham1206agra mentioned this issue Jan 15, 2025
Merged
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jan 15, 2025
@shubham1206agra
Copy link
Contributor

@mountiny Opened the revert #55296

@dukenv0307
Copy link
Contributor

@mountiny Should we revert this PR?

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 17, 2025
@mountiny mountiny added Help Wanted Apply this label when an issue is open to proposals by contributors and removed DeployBlockerCash This issue or pull request should block deployment labels Jan 17, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 17, 2025

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

This is fixed $50 to @shubham1206agra

@huult huult mentioned this issue Jan 21, 2025
Merged
50 tasks
@shubham1206agra
Copy link
Contributor

@muttmuure Can you start payment process as per #55275 (comment)?

@mallenexpensify
Copy link
Contributor

@shubham1206agra paid $50 via Upwork.

Thx for the help finding the offending PR

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Feb 3, 2025 •
edited
Loading

@madmax330 @muttmuure Can you please close this issue?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madmax330 madmax330

@muttmuure muttmuure

@shubham1206agra shubham1206agra

@dukenv0307 dukenv0307

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@madmax330 @mallenexpensify @vincdargento @mountiny @muttmuure @shubham1206agra @dukenv0307