[HOLD for payment 2025-01-30] [$250] Trip - No "Cancellation policy" field in the car trip details

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.78-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+0948501@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11
App Component: Other

Action Performed:

Precondition:

• Create a trip with steps from this PR [vip-travel] Create Trip Details Screen #52823
• User has created a car trip.

1. Go to staging.new.expensify.com
2. Go to trip room.
3. Go to trip thread.
4. Click View trip details.

Expected Result:

There should be a "Cancellation policy" field in the car trip details (it shows free cancellation on the travel site).

Actual Result:

There is no "Cancellation policy" field in the car trip details.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701793_1735046264090.bandicam_2024-12-24_21-12-10-610.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021880243921286668938
• Upwork Job ID: 1880243921286668938
• Last Price Increase: 2025-01-17

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[jasperhuangg]

This feature is locked behind a beta, so there's no need to block deploy on it. Assigning @blazejkustra to fix this since they worked on the PR introducing trip details.

[jasperhuangg]

Ah hmm, I can't do the assignment, but @blazejkustra please look into this when you can!

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[aldo-expensify]

@jasperhuangg the bug is affecting the header of pages outside of the trip stuff

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

@rlinoz, @blazejkustra, @Christinadobrzyn, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[blazejkustra]

Update: PR was approved by C+, waiting on review & merge from @rlinoz

[melvin-bot]

@rlinoz @blazejkustra @Christinadobrzyn @shubham1206agra this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[blazejkustra]

@MelvinBot PR was merged yesterday 🤷

[Christinadobrzyn]

watching PR - #55289

Moving this to weekly since it's going through staging/prod

[Christinadobrzyn]

PR in staging - #55289

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update cancellation logic for car reservations #55289

If no regressions arise, payment will be issued on 2025-01-30. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

@shubham1206agra @Christinadobrzyn @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Christinadobrzyn]

Payment coming up - @shubham1206agra do we need a regression test for this?

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @blazejkustra is from an agency-contributor and not due payment
• ROLE: @shubham1206agra paid $250 via Upwork https://www.upwork.com/nx/wm/offer/105929364

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1880243921286668938/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

@shubham1206agra do you want to be paid through ND when you're eligible (looks like that's soon)?

Do we need a regression test?

[shubham1206agra]

do you want to be paid through ND when you're eligible (looks like that's soon)?

Nope, I have to be paid via upwork for this issue.

[shubham1206agra]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/52823/files#r1936078618

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/465877

Regression Test Proposal

Precondition:

• Create a trip with steps from this PR [vip-travel] Create Trip Details Screen #52823
• User has created a car trip.

Test:

1. Go to App
2. Go to trip room.
3. Go to trip thread.
4. Click View trip details.
5. Verify that 'Free cancellation' is displayed in on details page

Do we agree 👍 or 👎

[Christinadobrzyn]

Thanks @shubham1206agra can you please accept my Upwork offer - https://www.upwork.com/nx/wm/offer/105929364

[shubham1206agra]

@Christinadobrzyn Offer accepted

[Christinadobrzyn]

Thanks @shubham1206agra! This is paid out based on this payment summary - #54536 (comment)

Closing as complete. Thanks everyone!