[$250] mWeb/Safari - WS Switcher - The back button does not respond when switching between workspaces

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue was found when executing this PR: #54030
Issue reported by: Applause Internal Team
Device used: iPhone 13
App Component: Other

Action Performed:

1.Open the app
2.Go to the WS switcher
3.Switch to/Filter by a workspace
4.Use device back button/gesture

Expected Result:

The app doesn't close but the app navigates to the previous workspace

Actual Result:

The back button does not respond when switching between workspaces

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701629_1735014119520.RPReplay_Final1735013297.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876256758509266830
• Upwork Job ID: 1876256758509266830
• Last Price Increase: 2025-02-17

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

[sonialiap]

Working part time through the holidays and prioritizing customer issues. Will look at this ASAP

[melvin-bot]

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876256758509266830

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

@s77rt @sonialiap this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[s77rt]

Still looking for proposals

[melvin-bot]

@s77rt, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Still waiting for proposals

[pac-guerreiro]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. User goes to workspace switcher page, then the history stack will be like this home > workspace switcher
2. User then selects a workspace and navigates back, then the history stack will be like this home.
3. User is unable to use browser go back button to return to workspace switcher

What is the root cause of that problem?

After selecting a workspace, the user navigates back to the previous page and the workspace switcher page is removed from history.

What changes do you think we should make in order to solve the problem?

Instead of navigating the user back, we can push the previous screen into the history stack so that the user is able to go back to workspace switcher page using browser's go back button.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

Still looking for proposals

[pac-guerreiro]

@s77rt this PR got merged yesterday and it might fix this issue. I'll investigate it!

[s77rt]

@pac-guerreiro Thanks you! Looking forward for your findings

[pac-guerreiro]

Screen.Recording.2025-02-12.at.15.51.01.mov

@s77rt the fix seems to be working with some minor bugs in main branch.

The minor bugs I see are the history getting reset while navigating forward sometimes. Also going all the way back seems to show a temporary broken home screen. I'm not sure what causes these issues but I'll take a look into the new code and see if I can fix them.

[s77rt]

@pac-guerreiro Thanks for checking. Given that the original issue is no longer reproducible I think we can close this one and the other issue can be handled as follow ups for the navigation refactor

[s77rt]

@sonialiap Let's close this one

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[s77rt]

@sonialiap We can close this

[pac-guerreiro]

@s77rt regarding the follow up issues, can I be tagged on them?

[s77rt]

cc @mountiny Do we have an issue for fixing surfaced issues from #49539

[mountiny]

@s77rt sorry, can you explain what you mean? We do track follow up issues by adding the [Navigation] prefix and SWM is going through them

[s77rt]

@pac-guerreiro Can you still reproduce this bug #54527 (comment)?

Just tested and seems to be working well:

Screen.Recording.2025-02-18.at.2.13.12.PM.mov

[pac-guerreiro]

Screen.Recording.2025-02-18.at.23.25.32.mov

@s77rt the issue where the home screen is shown as blank for a few seconds seems to be fixed, but moving in the history after will not show the correct workspace just home instead

[s77rt]

@pac-guerreiro Got it, thanks! I have reported this here https://expensify.slack.com/archives/C049HHMV9SM/p1739971259098259

[s77rt]

#57121

[s77rt]

@sonialiap We can close this

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[s77rt]

This can be closed

[pac-guerreiro]

@mountiny this issue can be closed 😄