[Payment due] [$250] LHN - "Removed 0 user" displayed on #Admins preview when room member leaves room.

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+71@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition: User B has to be an off-workspace member of the room.

1. Create a workspace
2. Create a workspace room (e.g #social)
3. Invite someone to the room that is not a member of the workspace
4. Log-in as the invited room member account
5. Leave the workspace room
6. Switch back to the inviter account
7. Observe the LHN preview of the #social room reads: "left the chat"
8. Observe the LHN preview of the #admins room reads: "left #social"
9. Click into the #admins room
10. Observe the LHN preview of the #admins room changes to "Removed 0 user"

Expected Result:

The #admins room LHN preview should continue to display the "left #%roomName" system message.

Actual Result:

The #admins room LHN preview changes to "Removed 0 user".

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021865059389537171212
• Upwork Job ID: 1865059389537171212
• Last Price Increase: 2024-12-13
• Automatic offers:
• FitseTLT | Contributor | 105371123

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

Hm, I don't see anything at all:

[FitseTLT]

Me too

[trjExpensify]

Ah, invite an off-workspace member perhaps?

[trjExpensify]

Yep, got it.

[trjExpensify]

Updated the steps in the OP to hopefully make it clearer.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021865059389537171212

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-06 16:03:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - "Removed 0 user" displayed on #Admins preview when room member leaves room.

What is the root cause of that problem?

We are not handling CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.LEAVE_ROOM separately

App/src/libs/SidebarUtils.ts

Line 437 in 48b80f6

} else if (ReportActionsUtils.isTaskAction(lastAction)) {

so it is falling back to the lastMessageText here

App/src/libs/SidebarUtils.ts

Lines 466 to 467 in 48b80f6

	} else if (lastAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && lastActorDisplayName && lastMessageTextFromReport) {
	result.alternateText = ReportUtils.formatReportLastMessageText(Parser.htmlToText(`${lastActorDisplayName}: ${lastMessageText}`));

which is 'remved 0 user'

What changes do you think we should make in order to solve the problem?

We can add

else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.LEAVE_ROOM) {
            const actionMessage = ReportActionsUtils.getReportActionMessageText(lastAction);
            result.alternateText = actionMessage ? `${lastActorDisplayName}: ${actionMessage}` : '';

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

we can create a test for getOptionData by passing the correct params, like a report whose last action is CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.LEAVE_ROOM type and assert that the alternateText is returned same as the action message of that report action 👍

What alternative solutions did you explore? (Optional)

may be it might be correct to remove the colon here so that it will say user left #room or even leave out lastActorDisplayName 👍

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The #admins room LHN preview changes to "Removed 0 user".

What is the root cause of that problem?

We don't have any special cases to handle CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.LEAVE_ROOM action. Then it's displayed lastMessageText by default

And it's wrong because OpenReport API is returning the wrong lastMessageText

What changes do you think we should make in order to solve the problem?

1. We need to fix from the backend side to return the correct lastMessageText.

And it's wrong because OpenReport API is returning the wrong lastMessageText

2. If we want to handle translation in the same way we do for CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.LEAVE_POLICY action. We can add a new case for this action in SidebarUtils, getReportName function, ReportActionItem, ContextMenuActions to handle translation for all places.

App/src/libs/SidebarUtils.ts

Line 465 in c013de6

} else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.LEAVE_POLICY) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@eVoloshchak, @trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

@eVoloshchak what do you think of the proposal? Thanks!

[melvin-bot]

@eVoloshchak, @trjExpensify Eep! 4 days overdue now. Issues have feelings too...

[trjExpensify]

@eVoloshchak can you review or hand off please? Thanks.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @trjExpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[trjExpensify]

@eVoloshchak bump again here.

[eVoloshchak]

@FitseTLT's proposal looks good to me!

🎀👀🎀 C+ reviewed!

[trjExpensify]

Thanks, Rajat. Looks like @eVoloshchak has reviewed today, question for @FitseTLT here.

[melvin-bot]

This issue has not been updated in over 15 days. @eVoloshchak, @trjExpensify, @Gonals, @FitseTLT eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Bumped the PR.

[FitseTLT]

Resolved conflicts and addressed comments on the PR waiting for @eVoloshchak Review 👍

[FitseTLT]

bump @eVoloshchak on the review Thx

[FitseTLT]

Bump @eVoloshchak

[FitseTLT]

Bump @eVoloshchak

[melvin-bot]

This issue has not been updated in over 15 days. @eVoloshchak, @trjExpensify, @Gonals, @FitseTLT eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[parasharrajat]

I can still help with review if needed cc: @trjExpensify

[trjExpensify]

Thanks! Looks like it was marked as ready for a re-review 4 days ago. @eVoloshchak can you confirm you can finalise the review of this PR in the next couple of days?

[eVoloshchak]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A, this was a case that wasn't considered

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: regression wasn't critical

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Create a workspace
2. Create a workspace room (e.g #social)
3. Invite someone to the room that is not a member of the workspace
4. Log-in as the invited room member account
5. Leave the workspace room
6. Switch back to the inviter account
7. Verify the LHN preview of the #admins room reads: "user: left #social" (not "Removed 0 user")

Do we agree 👍 or 👎

[eVoloshchak]

The automation has failed on this, the PR has been deployed to production on February 17th and is ready for payment

[eVoloshchak]

@trjExpensify, this should be ready for payment. Could you post a payment summary, please?

[trjExpensify]

Payment summary as follows:

• $250 to @eVoloshchak for the C+ review
• $250 to @FitseTLT for the PR

@FitseTLT I've paid you in Upwork. @eVoloshchak, are you paid in NewDot? An offer wasn't generated for you.

[eVoloshchak]

Yeah, I'll request this on ND. Thank you!

[trjExpensify]

Sounds good, closing!