Save button is not disabled even when User has not edited anything in Edit Workspace

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to newDot
2. Go to any Workspace page
3. Edit workspace
4. Even without editing anything "Save" Button will be active

Expected Result:

Button should be disabled when nothing has change

Actual Result:

Workaround:

Visual issue.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal

• I'll disable the button if the values aren't changed

        const isButtonDisabled = this.props.policy.name === this.state.name.trim();

[mallenexpensify]

on hold, will revisit in a week-ish

[mallenexpensify]

still on hold.. likely coming off soon..

[mallenexpensify]

@aman-atg , I think we should wait til people are allowed to create new workspaces on staging then check to see if the save button is still highlighted with no text in the box. I just tried to create a new workspace with no luck, it might be because I'm the 'Expensify' account though.

[aman-atg]

Well, we can do that but the issue was that the "Save" Button is being highlighted even when no editing was done.
Like for Profile and all other forms if user hasn't edited anything it should kept disabled.

[mallenexpensify]

Ok, I think I'm seeing it now. It's a low value issue but, we should be consistent between having the save button not highlighted in edit workspace if there are no changes like it is in profile edit.

Moving along to an engineer for more eyes.

[MelvinBot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tylerkaraszewski]

This seems fairly trivial. And not really that important, but if we do it in the rest of the app, then consistency is nice. Sure, go ahead.

[MelvinBot]

Triggered auto assignment to @timszot (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Job posted - https://www.upwork.com/jobs/~018a28b490d8741d12
@timszot , can you review @aman-atg 's proposal here #4490 (comment)

[mananjadhav]

I'd like to highlight that I was asked to resolve this as a part of this PR #4801 . Please refer this comment #4487 (comment)

[timszot]

Looks good to me! @mallenexpensify let's hire @aman-atg for his proposal.

[mallenexpensify]

@mananjadhav are you suggesting that if we put this issue on hold, it'll end up being fixed by one/both of the issues you linked above?

[mananjadhav]

Yes, @mallenexpensify. Save button is enabled only when the image or title is changed. It was just merged today.

@aman-atg and @timszot can also confirm. Following is code change that handles it.

 const isButtonDisabled = policy.isAvatarUploading 
                                              || (this.state.avatarURL === this.props.policy.avatarURL          
                                                     && this.state.name === this.props.policy.name);

[aman-atg]

Cool, this can be closed now. (As the issue is already fixed by another PR)