Search-Expense details updated are not shown immediately

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch app
2. Tap fab -- submit expense
3. Create a expense with an user
4. Navigate to lhn
5. Tap profile -- troubleshoot -- new search
6. Tap on the expense
7. In IOU details page, change amount
8. Note in search page, amount not updated
9. Tap on the expense
10. Enter merchant and note in search page, merchant also not updated
11. Tap chat icon and from profile -- troubleshoot -- new search revisit page
12. Note now updated amount and merchant is shown

Expected Result:

In search page, expense details updated must be shown immediately.

Actual Result:

In search page, expense details updated are not shown immediately, shown only while revisiting page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6482099_1715812292152.real.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@dylanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[youssef-lr]

can we check again if this is reproducible in prod?

[kavimuru]

@youssef-lr we don't have "testing preference" in production. So, we can't check it.

[dylanexpensify]

@youssef-lr checking in on this, need anything from me so far?

[youssef-lr]

Nothing yet @dylanexpensify, thanks! I'm trying to reproduce this now.

[youssef-lr]

Demoting this given that this only affect the new search page which is only accessible from staging

[melvin-bot]

@youssef-lr, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dylanexpensify]

sounds good!

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify 12 days overdue now... This issue's end is nigh!

[abdulrahuman5196]

instead can we fetch it as a whole and update the data before sending it to all the row items?

@abdulrahuman5196 Of course we can, we can simply get it in batch in the list and pass down to the rows.

But this might lead to the whole list rendering when only 1 row data changes, although we can mitigate it by memoization.

@dominictb Seems good. Can you update the proposal with the relevant information on how you would do it as an alternate solution? So that we can review the proposal as a whole again

[dylanexpensify]

Pending @dominictb to update proposal

[dominictb]

I'll update the proposal by tomorrow!

[abdulrahuman5196]

Expecting proposal update by tomorrow

[dominictb]

Seems there has been some code and behavior differences compared to when I posted my proposal. I need some more time check it more deeply and will update in a day.

[dylanexpensify]

@dominictb let's get it posted today! 🙌

[dominictb]

@dylanexpensify @abdulrahuman5196 I can no longer reproduce this, I think another PR has fixed it, I've checked and not completely sure which PR fixes this, but it's likely this one Expensify/react-native-onyx#552

I think we can add Retest label here

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[abdulrahuman5196]

Need to re-test this

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify 10 days overdue. Is anyone even seeing these? Hello?

[abdulrahuman5196]

@youssef-lr / @dylanexpensify We can close this issue. Issue not reproducible.

Screen.Recording.2024-07-24.at.1.49.43.PM.mov

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@youssef-lr, @abdulrahuman5196, @dylanexpensify Still overdue 6 days?! Let's take care of this!

[abdulrahuman5196]

@dylanexpensify / @youssef-lr We can close this issue - #42254 (comment)