[$250] Web -Send Invoice - Comments sent after an invoice get hidden when returning to invoice report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Send an invoice to user B
3. Open the invoice room and send a comment
4. Click on the IOU to open the expense details page
5. Click on the header to go back to the invoice room

Expected Result:

The IOU gets highlighted and the comment under the IOU will be visible

Actual Result:

Only the IOU is seen and the comment under the IOU is hidden

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466372_1714468680236.bandicam_2024-04-30_12-09-00-689.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e2e9b3f101f09fc
• Upwork Job ID: 1785304503598456832
• Last Price Increase: 2024-05-07

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Julesssss]

Invoice highlighting is a new feature that isn't possible on production, so this shouldn't be considered a blocker.

[Julesssss]

Prod

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011e2e9b3f101f09fc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignee @Santhosh-Sellavel is eligible for the External assigner, not assigning anyone new.

[Julesssss]

Hmm, our automation didn't assign a BZ team member

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cristipaval]

#vip-billpay related cc @danielrvidal

[trjExpensify]

Yeah, it looks like that's a comment linking issue broadly.

1. Scroll back in a chat you have a lot of history
2. Go to a thread / or start one
3. Click the hyperlink in the page header to return to the page header
4. Observe the chat beneath the parent comment can't be scrolled.

I'd suggest moving this to #vip-vsb. CC: @roryabraham as well!

[danielrvidal]

@roryabraham is there already an issue for this or should we move it over to #vip-vsb?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@Julesssss, @trjExpensify, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

[Julesssss]

@roryabraham is there already an issue for this or should we move it over to #vip-vsb?

Bumping this question, not sure what to do here yet.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

Seems like this bug is associated with a PR. I am an author. I am going to fix it like a regression.

[rezkiy37]

Just opened a draft PR. Will opened for review soon 🙂

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[rezkiy37]

The PR has been merged.

[Santhosh-Sellavel]

Please assign @mananjadhav for C+ here as he reviewed PR!

[mananjadhav]

Thanks for assigning. The PR was deployed to production 4 days ago. Waiting for regression period to be completed.

[mananjadhav]

@trjExpensify Can you please help with the payout summary? The offending PR was already identified before I was assigned.

I don't think we need a regression test for this one.

[trjExpensify]

Agreed, the regression tests for the invoice project should get added centrally as part of the project.

Payment summary as follows:

$250 to @mananjadhav for the C+ review of the PR.

Feel free to request. Closing!

[mananjadhav]

Thanks @trjExpensify

[JmillsExpensify]

$250 approved for @mananjadhav