[HOLD for payment 2024-05-22] [$250] Android - Scan - Uploading corrupt pdf as scan receipt, error not shown under preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/runs/view/20905&group_by=cases:section_id&group_order=asc&group_id=294998
**Issue reported by:**Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a workspace report
3. Tap plus icon -- submit expense -- scan
4. Upload a corrupt pdf
5. Tap submit expense

Expected Result:

Error message "Receipt didn't upload, download the file or dismiss this error" under preview must be shown in conversation page

Actual Result:

Error message "Receipt didn't upload, download the file or dismiss this error" under preview not shown in conversation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6465582_1714412445807.didnt.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01020aa616d70323c3
• Upwork Job ID: 1785345183089377280
• Last Price Increase: 2024-04-30

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The scan request error in transaction thread shows a generic error message instead of "Receipt didn't upload, download the file or dismiss this error".

What is the root cause of that problem?

When we create a new scan request, we set a generic error to the transaction when fails.

App/src/libs/actions/IOU.ts

Lines 737 to 739 in 2a1c2cb

	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`,
	value: {
	errors: ErrorUtils.getMicroSecondOnyxError('iou.error.genericCreateFailureMessage'),

But for the report action, we set the receipt error correctly.

App/src/libs/actions/IOU.ts

Line 753 in 2a1c2cb

errors: getReceiptError(transaction.receipt, transaction.filename || transaction.receipt?.filename, isScanRequest, errorKey),

What changes do you think we should make in order to solve the problem?

Set the receipt error for the transaction too.

errors: getReceiptError(transaction.receipt, transaction.filename || transaction.receipt?.filename, isScanRequest, errorKey),

We need to do this for other request too such as invoice/track.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01020aa616d70323c3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

@puneetlath, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

Thank you @bernhardoj Your Proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[bernhardoj]

PR is ready

cc: @fedirjh

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Set receipt error instead of generic error when failed uploading receipt #41720

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment (Needs manual offer from BZ)
• @bernhardoj requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

BugZero Checklist:

• Link to the PR: N/A this is not a regression, it's an improvement rather than bugfix
• Link to comment: N/A
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: Already have this one: https://expensify.testrail.io/index.php?/runs/view/20905&group_by=cases:section_id&group_order=asc&group_id=294998

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @fedirjh paid $(AMOUNT) via Upwork (LINK)
• ROLE: @bernhardoj paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1785345183089377280/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

@fedirjh offer: https://www.upwork.com/nx/wm/offer/102440614
@bernhardoj offer: https://www.upwork.com/nx/wm/offer/102440609

Please ping me here when you've accepted

[fedirjh]

@puneetlath Thank you. Accepted 🎉

[bernhardoj]

@puneetlath thanks, accepted

[puneetlath]

All paid. Thanks everyone!