[HOLD for payment 2024-04-15] [$125] Feature Request: Update the @here text to change "room" to "chat"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem:

Use of the term "room" is confusing to users when they want to @here in a thread, since it's not obvious if it will tag only people in the thread or everybody in the whole channel.

Solution:

Update the @here text to change "room" to "chat".

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711567928507609

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019f60e1f0a5d015f5
• Upwork Job ID: 1773464003280478208
• Last Price Increase: 2024-03-28

[melvin-bot]

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the @here text to change "room" to "chat"

What is the root cause of that problem?

We currently use the word as room

App/src/languages/en.ts

Lines 519 to 520 in e542ba7

	mentionSuggestions: {
	hereAlternateText: 'Notify everyone online in this room',

App/src/pages/home/report/ReportActionCompose/SuggestionMention.tsx

Line 156 in e542ba7

alternateText: translate('mentionSuggestions.hereAlternateText'),

What changes do you think we should make in order to solve the problem?

Update the above to Notify everyone in this conversation

same should be done to the spanish translation
Rought spanish translation would be: Notificar a todos en esta conversación (this will be improved)

What alternative solutions did you explore? (Optional)

N/A

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Feature Request: Update the @here text to change "room" to "chat"

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

To fix this issue we need update text here

App/src/languages/en.ts

Line 520 in e542ba7

hereAlternateText: 'Notify everyone online in this room',

hereAlternateText: 'Notify everyone online in this chat',

And here

App/src/languages/es.ts

Line 516 in 4844b40

hereAlternateText: 'Notificar a todos los que estén en linea de esta sala',

hereAlternateText: 'Notificar a todos los que estén en linea de esta chat',

What alternative solutions did you explore? (Optional)

NA

[rafecolton]

Please hold 🙏 we are still discussing the exact text of this message and may want to edit it further

[rafecolton]

Latest here (internal only) - cc @JmillsExpensify

[ghost]

I think then you should put this issue on hold @rafecolton for now

[rafecolton]

Ok, off hold, we are changing it to @here Notify everyone in this conversation - note the removal of "online" and changing "chat" to "conversation"

[allgandalf]

Updated proposal

[rafecolton]

@sakluger I think this can easily be done by a contributor. Both proposals are nearly identical and @GandalfGwaihir's came in about one minute before. I looked at the edit history and they did originally mention the Spanish translation as well. So I think we should go with their proposal.

[sakluger]

Thanks @rafecolton. Given how simple this change is, I'm going to set the price at $125. Let me know if you disagree.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019f60e1f0a5d015f5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

❌ There was an error making the offer to @GandalfGwaihir for the Contributor role. The BZ member will need to manually hire the contributor.

[allgandalf]

PR ready for review @allroundexperts :)

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Feature Request]: Update the @here text to change "Notify everyone online in this room" to "Notify everyone in this conversation" #39221

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @GandalfGwaihir requires payment (Needs manual offer from BZ)

[sakluger]

Summarizing payment on this issue:

Contributor: @GandalfGwaihir $125, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/101873661/)
Contributor+: @allroundexperts $125, please request on Newdot

[allgandalf]

Accepted, Thanks

[sakluger]

Completed the payment! @allroundexperts I'm closing the issue, feel free to request payment now 🙇‍♂️

[JmillsExpensify]

$125 approved for @allroundexperts