[HOLD for payment 2024-04-05] [QAB] Create the Quick Action button

[Gonals]

As described in this section of the design doc, we want to add a Quick Action button to Global Create.

The changes to skip the confirmation screen will be done in a different issue

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01244e26ed86f405a4
• Upwork Job ID: 1767202396900225024
• Last Price Increase: 2024-03-11

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01244e26ed86f405a4

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[joekaufmanexpensify]

Held.

[Gonals]

OFF HOLD

[parasharrajat]

PR merged.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Display Quick Action Button #38669

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[joekaufmanexpensify]

@parasharrajat could you please complete your portion of checklist?

[parasharrajat]

Regression Test Steps

1. Log into newDot from a new account
2. Open the Global Create menu. Confirm no additional item is displayed.
3. Request Money (manual) from someone
4. After completing the request, confirm it displays as a quick action in the Global create menu.
5. Confirm You can complete the request from the quickAction, and that it points to the same user the original request did.
6. Repeat the same steps, but requesting with a receipt.
7. And again, but with distance.
8. Confirm all of them work for Money requests from workspaces too.
9. Confirm all of them work for Split requests too.
10. Send money to someone and, again, confirm it later displays as a a quick action and that it works.
11. Assign a task to someone and confirm it later displays as a a quick action and that it works.

Do you agree 👍 or 👎 ?

[joekaufmanexpensify]

Sounds good! I'll work on getting that created.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot

BugZero Checklist (@joekaufmanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1767202396900225024/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[joekaufmanexpensify]

Going to create regression test today, and then will be all set to issue payment

[joekaufmanexpensify]

Actually, I see we have a detailed manual testing script here that covers this case (any others) in more detail. @trjExpensify @Gonals I assume the plan is to just pass off that script to applause to make tests for all of the various cases at once after testing?

If so, I'll hold off on creating any tests here.

[joekaufmanexpensify]

In the meantime, only payment here is $500 to @parasharrajat via NewDot for C+ review. Could you please request that and confirm here once complete?

[trjExpensify]

Actually, I see we have a detailed manual testing script here that covers this case (any others) in more detail. @trjExpensify @Gonals I assume the plan is to just pass off that script to applause to make tests for all of the various cases at once after testing?

Yep, that's the plan once we're done with the issues for the project!

[joekaufmanexpensify]

Cool. TY!

[joekaufmanexpensify]

Bump @parasharrajat for when you have a sec!

[parasharrajat]

@joekaufmanexpensify I will request that later. Feel free to close it. Thanks.

[joekaufmanexpensify]

Got it. TY! Payment summary is here.

[parasharrajat]

As per this thread https://expensify.slack.com/archives/C02NK2DQWUX/p1715272276516799?thread_ts=1715190852.677769&cid=C02NK2DQWUX, the price should be 500 for this issue. @joekaufmanexpensify

Could you please update that on the summary?

[joekaufmanexpensify]

Brought to slack to discuss

[joekaufmanexpensify]

Discussed, and confirmed that @parasharrajat is actually due $500 here, since this issue was opened prior to the adjustment of base review price from $500 > $250.

[joekaufmanexpensify]

Adjust payment summary to reflect that, which is noted here.

[parasharrajat]

Payment requested as per #38050 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat