[HOLD for payment 2024-02-26] [$500] Android -In offline, "pay elsewhere" is clearly visible in mweb but less visible in Android

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.24
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app in both mweb and app
2. Tap on a Workspace chat
3. Tap plus icon ---- Request money --- manual
4. Enter an amount and tap next
5. Enter Merchant field and tap save
6. Tap request
7. Select Pay elsewhere option
8. Turn off mobile data
9. Note "pay elsewhere" text in both mweb and Android

Expected Result:

In WS chat, "pay elsewhere" text must be clearly visible in both mweb and Android in offline

Actual Result:

In WS chat, "pay elsewhere" text is clearly visible in mweb but less visible in Android in offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6338891_1704981158532.az_recorder_20240111_023130.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae616c384617e80b
• Upwork Job ID: 1745446040782819328
• Last Price Increase: 2024-02-01

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ae616c384617e80b

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we create a money request to our own policy expense chat while offline, the "Pay elsewhere" button text is not really visible on Android.

What is the root cause of that problem?

This is a common issue on Android (one of the examples #15283) where a stacking component with opacity is applied to the parent, all of its children "inherit" that opacity. So, the opacity is applied to the button and the text too.

(more info, the same reference I put in #15283 (comment))

What changes do you think we should make in order to solve the problem?

We can use the same solution from the previous issue, that is by setting needsOffscreenAlphaCompositing to ReportPreview OfflineWithFeedback.

In MoneyRequestPreview, we already set the needsOffscreenAlphaCompositing, but the component used in this case is ReportPreview which doesn't have it yet

[abdulrahuman5196]

Will take a look today.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Sorry for the delay. Will close out the review.

[abdulrahuman5196]

Reviewing now

[miljakljajic]

Being reviewed

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[miljakljajic]

How are we doing with this one?

[abdulrahuman5196]

Hi, Will review proposals today.

[bernhardoj]

PR is ready

cc: @abdulrahuman5196

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix report preview settlement button text is less visible on Android #36315

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment (Needs manual offer from BZ)
• @bernhardoj requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Seems to be the issue from start.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Won't be beneficial for this minor issue.

@miljakljajic

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @abdulrahuman5196 paid $(AMOUNT) via Upwork (LINK)
• ROLE: @bernhardoj paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@miljakljajic)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1745446040782819328/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[hayata-suenaga]

melvin, we're just waiting for payment

[abdulrahuman5196]

@miljakljajic Gentle ping on payment processing here

[miljakljajic]

Apologies, sharing payment summaries for both of you based on this comment: #34354 (comment)

@abdulrahuman5196 is owed 500 USD
@bernhardoj is owed 500 USD

[abdulrahuman5196]

@miljakljajic I am still paid on upwork. Could you kindly process the upwork request?

[miljakljajic]

Of course - is that your proposal on the job posting?

[abdulrahuman5196]

Upwork Job

@miljakljajic Applied on the job above now.

[miljakljajic]

sent an offer!

[abdulrahuman5196]

Accepted the offer

[miljakljajic]

Paid :)

[abdulrahuman5196]

Thank you. @miljakljajic

[bernhardoj]

Applied to the job too.

[bernhardoj]

@miljakljajic can you process mine too, thanks