[$125] Cancel payment - "Cancel payment" in three-dot menu is not translated to Spanish

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32674

Action Performed:

1. Go to workspace chat
2. Create a manual request
3. Open expense report
4. Click Pay elsewhere
5. Change app language to Spanish
6. Click 3-dot menu

Expected Result:

In Step 6, "Cancel payment" in 3-dot menu is translated to Spanish

Actual Result:

In Step 6, "Cancel payment" in 3-dot menu is not translated to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324157_1703264609496.bandicam_2023-12-22_17-27-03-380__2_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018f27688bf279c909
• Upwork Job ID: 1738316307016527872
• Last Price Increase: 2023-12-22

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cancel payment - "Cancel payment" in three-dot menu is not translated to Spanish




What is the root cause of that problem?

We did not translate ‘Cancel Payment’ in threeDots menu





What changes do you think we should make in order to solve the problem?

We should use the key iou.cancelPayment and use the translate hook:

App/src/languages/en.ts

Line 554 in 235c7b7

cancelPayment: 'Cancel payment',

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cancel payment not translated to spanish

What is the root cause of that problem?

We have static string here which added in this PR

App/src/components/MoneyReportHeader.js

Line 124 in b0e038f

text: 'Cancel payment',

What changes do you think we should make in order to solve the problem?

We need to use translation key instead.

text: translate('iou.cancelPayment'),

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018f27688bf279c909

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[puneetlath]

Not a deploy blocker but we should fix this. Going to make it a $125 issue as this is very simple.

[melvin-bot]

Upwork job price has been updated to $125

[getusha]

Since the issue is straightforward, let's proceed with @neonbhai's proposal, as it was the first one.
🎀 👀 🎀 C+ Reviewed!

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[neonbhai]

I raised the fix not realising the assignment didn't happen. I'm sorry 🙇
won't happen again

[mountiny]

Reverting the original PR because it has caused numerous deploy blockers and the author is ooo

[marcaaron]

Closing since related PR was reverted. cc @Gonals