Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🎨🐛 Status Page Color Is Incorrect in Both Themes #33091

Closed
grgia opened this issue Dec 14, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Dec 14, 2023

https://expensify.slack.com/archives/C03TME82F/p1702572893347079?thread_ts=1702568492.702179&cid=C03TME82F

Image

Should be AppBG

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a92f5e573321b5c2
  • Upwork Job ID: 1735359468152483840
  • Last Price Increase: 2023-12-14
@grgia grgia self-assigned this Dec 14, 2023
@grgia grgia converted this from a draft issue Dec 14, 2023
@situchan
Copy link
Contributor

Same issue created here - #33087

@grgia grgia added the NewFeature Something to build that is a new item. label Dec 14, 2023
Copy link

melvin-bot bot commented Dec 14, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 14, 2023
@grgia grgia added Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 labels Dec 14, 2023
Copy link

melvin-bot bot commented Dec 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a92f5e573321b5c2

Copy link

melvin-bot bot commented Dec 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @getusha (Internal)

Copy link

melvin-bot bot commented Dec 14, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 19, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching] 🎨🐛 Status Page Color Is Incorrect in Both Themes [HOLD for payment 2023-12-26] [Theme Switching] 🎨🐛 Status Page Color Is Incorrect in Both Themes Dec 19, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 19, 2023
Copy link

melvin-bot bot commented Dec 19, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 19, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-26] [Theme Switching] 🎨🐛 Status Page Color Is Incorrect in Both Themes [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🎨🐛 Status Page Color Is Incorrect in Both Themes Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @getusha requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 21, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 25, 2023
Copy link

melvin-bot bot commented Dec 28, 2023

@grgia, @zanyrenney, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

@getusha
Copy link
Contributor

getusha commented Dec 29, 2023

I don't think this needs regression test steps, it doesn't seem a bug that'll occur on this specific page in the future.
what do you think @grgia?

Copy link

melvin-bot bot commented Jan 1, 2024

@grgia, @zanyrenney, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 1, 2024

@grgia, @zanyrenney, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia
Copy link
Contributor Author

grgia commented Jan 2, 2024

@getusha I agree on regression steps. @zanyrenney I think this one can be closed once paid for!

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@zanyrenney
Copy link
Contributor

@getusha please apply for the job here - https://www.upwork.com/jobs/~01a92f5e573321b5c2

@getusha
Copy link
Contributor

getusha commented Jan 5, 2024

@zanyrenney applied

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@zanyrenney
Copy link
Contributor

offer sent @getusha

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
@getusha
Copy link
Contributor

getusha commented Jan 8, 2024

@zanyrenney Accepted!

@zanyrenney
Copy link
Contributor

from the comment:

For reference, here are some details about the assignees on this issue:

@getusha requires payment (Needs manual offer from BZ)

Payment sent.

Payment summary $500. Thanks, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

4 participants