Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-28] [Theme Switching] 🎨🐛 Draft Card Preview Hover Color Is Incorrect in Both Themes #33078

Closed
grgia opened this issue Dec 14, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Dec 14, 2023

https://expensify.slack.com/archives/C049HHMV9SM/p1702569789849209

Issue OwnerCurrent Issue Owner: @JmillsExpensify
@grgia grgia converted this from a draft issue Dec 14, 2023
@grgia grgia self-assigned this Dec 14, 2023
@grgia grgia added the Daily KSv2 label Dec 14, 2023
@grgia grgia changed the title [Theme Switching] 🎨🐛 Draft Hover Color Is Incorrect in Both Themes [Theme Switching] 🎨🐛 Draft Card Preview Hover Color Is Incorrect in Both Themes Dec 14, 2023
@ishpaul777
Copy link
Contributor

hey @grgia! Notice this on status page, screenwrapper in src/pages/settings/Profile/CustomStatus/StatusPage.js has a green BG

Screenshot 2023-12-14 at 10 12 16 PM

@grgia
Copy link
Contributor Author

grgia commented Dec 14, 2023

@ishpaul777 thank you- we have an issue here! #33091

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Dec 14, 2023
@melvin-bot melvin-bot bot changed the title [Theme Switching] 🎨🐛 Draft Card Preview Hover Color Is Incorrect in Both Themes [HOLD for payment 2023-12-28] [Theme Switching] 🎨🐛 Draft Card Preview Hover Color Is Incorrect in Both Themes Dec 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 27, 2023
Copy link

melvin-bot bot commented Jan 1, 2024

@grgia Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 1, 2024

@grgia Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@grgia grgia added Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Jan 2, 2024
Copy link

melvin-bot bot commented Jan 2, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

This comment was marked as off-topic.

@grgia
Copy link
Contributor Author

grgia commented Jan 2, 2024

@JmillsExpensify could you help me out with ensuring that @fedirjh receives the $500 C+ review payment for review of #33097

@melvin-bot melvin-bot bot added the Overdue label Jan 5, 2024
@grgia
Copy link
Contributor Author

grgia commented Jan 5, 2024

awaiting payment verification

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 5, 2024
Copy link

melvin-bot bot commented Jan 9, 2024

@JmillsExpensify, @fedirjh, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia
Copy link
Contributor Author

grgia commented Jan 9, 2024

@JmillsExpensify could you verify payments / close this one out 🙏

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 9, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

@JmillsExpensify, @fedirjh, @grgia Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 17, 2024

@JmillsExpensify, @fedirjh, @grgia Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jan 19, 2024

@JmillsExpensify, @fedirjh, @grgia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@JmillsExpensify
Copy link

Whoops, sorry for the delay. Payment summary: $500 @fedirjh for PR review and testing.

@melvin-bot melvin-bot bot removed the Overdue label Jan 24, 2024
@JmillsExpensify
Copy link

Offer sent!

@fedirjh
Copy link
Contributor

fedirjh commented Jan 24, 2024

@JmillsExpensify Thank you. Accepted.

@JmillsExpensify
Copy link

Contract paid out! Thanks @fedirjh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
No open projects
Development

No branches or pull requests

4 participants