[HOLD for payment 2024-01-17] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestTag - Split out into its own command

[tgolen]

There will be three pieces to this:

• Auth: Using the logic from EditMoneyRequest, create a new command called UpdateMoneyRequestTag following the example in https://github.com/Expensify/Auth/pull/8986
• Web-E: Add a new API endpoint called UpdateMoneyRequestTag following the example in https://github.com/Expensify/Web-Expensify/pull/39445
• App: Implement the new API command following the example in Implement new UpdateMoneyRequestDate API endpoint #30737

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01307ca29530c2a1a3
• Upwork Job ID: 1730347003188379648
• Last Price Increase: 2023-11-30

Issue Owner

Current Issue Owner: @anmurali

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01307ca29530c2a1a3

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[aldo-expensify]

@tgolen 👋 , I'm guessing that for the Auth part we want to reuse this MoneyRequest class and add the tag when we load the transaction here:

https://github.com/Expensify/Auth/blob/0c3ae5c2ee23daf8aada8a4c4c13eba896544a75/auth/lib/MoneyRequest.cpp#L30-L50

does that sound correct?

[tgolen]

Yeah, exactly! @luacmartins has added a few more fields to that, so be careful with conflicts.

[aldo-expensify]

Nice, thanks!

[aldo-expensify]

Made the Web-E and Auth PR ready for review. I'm going to work on finishing the App PR now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add UpdateMoneyRequestTag command #32769

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel requires payment through NewDot Manual Requests

[Santhosh-Sellavel]

@aldo-expensify Can you help with BZ Checklist here?

Also can you assign a BZ here?

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aldo-expensify]

Added Bug to get a BugZero member

[aldo-expensify]

Not overdue, payment period still open

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @Santhosh-Sellavel owed $500 via NewDot

BugZero Checklist (@anmurali)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1730347003188379648/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@anmurali, @Santhosh-Sellavel, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

@Santhosh-Sellavel I have run through the payment checklist #32312 (comment). You can request via ND.

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$500 approved for @Santhosh-Sellavel based on this comment.