[HOLD for payment 2024-01-25] [$500] Web - "Bank account" option does not appear in "Wallet"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.4.-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32079

Action Performed:

1. Go to settings > wallet
2. Add bank account

Expected Result:

Bank account option appears

Actual Result:

Only debit card option appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ea0db427c9d793c6
• Upwork Job ID: 1729294846848581632
• Last Price Increase: 2023-12-12

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ea0db427c9d793c6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[jgddesigns]

Is there a reason why this error doesn't occur in dev, but does occur in staging?

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only debit card option appears

What is the root cause of that problem?

We're only showing Personal bank account if we can validate the IOU report passed in, based on this condition. In Wallet page, there'll be no IOU report passed in so canUseBusinessBankAccount is always false.

What changes do you think we should make in order to solve the problem?

Always show Personal bank account if the AddPaymentMethodMenu is from WalletPage. This can be done by updating the canUsePersonalBankAccount check to:

• Check if iouReport is empty, if yes always show Personal bank account, only if it's not empty, we'll check other conditions related to the iouReport

isEmpty(iouReport) ||
...rest

• Or use a new prop to indicate it's from wallet page, or more precisely from non-IOU flow

Update: The prop I mentioned has been added via this PR so we can just use it

What alternative solutions did you explore? (Optional)

NA

[endless-runner-007]

Contributor details
Your Expensify account email: semenovihor95@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0132b61da48807943c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[it-education-md]

I cannot find this bug on dev

[kaushiktd]

Please re-state the problem that we are trying to solve in this issue.

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

According to below condition, Bussiness Bank Account option is showing only when iouReport is not empty and return true. but if iouReport is empty it will always return false, So only debit option is showing in wallet.

const canUseBusinessBankAccount =
        ReportUtils.isExpenseReport(iouReport) ||
        (ReportUtils.isIOUReport(iouReport) && !ReportActionsUtils.hasRequestFromCurrentAccount(lodashGet(iouReport, 'reportID', 0), lodashGet(session, 'accountID', 0)));

What changes do you think we should make in order to solve the problem?

You need to check iouReport is empty or not in below mention file with updated code values.
https://github.com/Expensify/App/blob/main/src/components/AddPaymentMethodMenu.js#L69

const canUseBusinessBankAccount =
        _.isEmpty(iouReport) ||
        ReportUtils.isExpenseReport(iouReport) ||
        (ReportUtils.isIOUReport(iouReport) && !ReportActionsUtils.hasRequestFromCurrentAccount(lodashGet(iouReport, 'reportID', 0), lodashGet(session, 'accountID', 0)));

Video

Screen.Recording.2023-11-28.at.11.04.43.AM.mov

[ra-md]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account option does not appear in wallet page

What is the root cause of that problem?

Here, we check if the report prop is an IOU report. If it returns true, the bank account option will appear. However, in the wallet page, there is no IOU report, so the bank account option will not appear.

What changes do you think we should make in order to solve the problem?

Since there is no IOU report on the wallet page, we can utilize router.name from useRouter to check whether the AddPaymentMethodMenu component is used on the wallet page and update the condition here like this:

ReportUtils.isIOUReport(iouReport) || route.name === SCREENS.SETTINGS.WALLET

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @ra-md! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@muttmuure, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@muttmuure, @aimane-chnaif Still overdue 6 days?! Let's take care of this!

[aimane-chnaif]

Need to clarify the expected behavior

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix show personal bank account option in wallet page #33694

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment (Needs manual offer from BZ)
• @tienifr requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[muttmuure]

@aimane-chnaif - $500
@tienifr - $500

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: Create v1 Collect workspace Bottom Up flow #30582
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30582/files#r1469718563
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

There's already regression test (caught by QA) so no need another one

[muttmuure]

Created a payment issue

[muttmuure]

Paid up

[tienifr]

Created a payment issue

Hi @muttmuure would you mind linking the issue/Upwork job you created for payment?

Somehow I haven't been able to find it.

Thanks!

[tienifr]

Hi @muttmuure would you mind linking the issue/Upwork job you created for payment?

@muttmuure Bump on this, thanks!

[muttmuure]

So sorry @tienifr! I must have not completed the full payment steps or hit an error. I have sent you a new offer

[tienifr]

Thanks for looking into this!

So sorry @tienifr! I must have not completed the full payment steps or hit an error. I have sent you a new offer

I've submitted a proposal to the Upwork invitation you sent!

[tienifr]

@muttmuure Could we proceed with next step here?

Thanks!

[muttmuure]

Sorry, not sure what happened there. Anyway, everyone has been paid.