[PAID] mWeb - Top bar color is different

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon
2. Check the top bar color

Expected Result:

Top bar color should not be different

Actual Result:

Top bar color is different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1695724253.MP4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695724265178069

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Everybody was OOO, so I assigned 10 random eligible people.

[dummy-1111]

This is a regression of this PR
We changed the overlay color here

[ishpaul777]

Proposal

Problem

mWeb - Top bar color is different

Root Cause

I dont think this is a regression, the color is intentionally changed to sidebar(previous color) color which is darkHighlightBackground Changing the color of the overlay across the App was in the scope of PR. We have been guided to not to touch darkHighlightBackground - here,

Changes

We can replace the color here to the overlay color (or a color decided by design team) instead of sidebar so that the issue can be prevented in future incase the color of overlay changes.

[situchan]

This should have been covered in #27920.
Was there any discussion about status bar color mismatch?

[ishpaul777]

No, there was no discussion.

[jasperhuangg]

Normally for these types of regressions we let the contributor who introduced the regression fix it. I commented on the PR raising the issue.

No need to block deploy on this, since it's such a minor display bug.

[s77rt]

@ishpaul777 We need to fix this app wide and not limited to the sidebar. e.g. if you got to a chat and press the plus grey button a modal will appear and the status bar color won't much. Can you please update your proposal addressing this?

[ishpaul777]

@s77rt The changes suggested will also changes the statusbar color app wide to overlay color. (#1A3D32)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: status bar color when modal is visible #28407

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @gadhiyamanan - $50
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jasperhuangg]

Assigning Bug to handle payment cc @strepanier03

[strepanier03]

Thanks, @jasperhuangg - I'll work on this now since it's two days past the payment date. I'll have an update soon.

[strepanier03]

@jasperhuangg - Quick question here. I see that the PR was submitted by @ishpaul777 but they aren't listed as the contributor here, not are they assigned to this GH.

I don't want to shortchange them and not pay when we should. Do you have any context into why they aren't listed as needing payment? Was there some special circumstances here that I'm missing?

[ishpaul777]

This was regression from my PR, unless I am missing something(this was first time i fixed a regression) no payment requires for regression fixes.

[s77rt]

@strepanier03 No payment is due here except for the bug reporter

[melvin-bot]

@Beamanator, @strepanier03, @jasperhuangg, @stitesExpensify, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stitesExpensify]

@strepanier03 can we get this paid out so that we can close the issue please? 😄

[strepanier03]

Sure thing @stitesExpensify - I had a question about payment that's resolved now, and it's my Monday so I'm only just getting back online from the weekend.

[strepanier03]

@gadhiyamanan - I've hired you to the job, please accept as soon as you can and I'll keep an eye out for it so I can pay.

[gadhiyamanan]

@strepanier03 offer accepted, thanks!

[strepanier03]

Thank you @gadhiyamanan - I've paid you via Upwork and closed the contract. Closing this now.