[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689

lanitochka17 · 2023-08-22T14:39:18Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Launch app
Tap fab
Tap assign task
Enter title
Tap next
Select any user for Share somewhere
Tap confirm task
From the Confirmed Task screen
Tap assignee
Select any user - button unresponsive = you can't add an assignee

You can add an assignee by

Find a Task in the LHN > tap Assignee > you can assign one

Expected Result:

Tapping on any contact, user must be able to select assignee

Actual Result:

Tapping on any contact, user unable to select assignee

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173366_cache.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01198bfad5e1717772
Upwork Job ID: 1694077716312887296
Last Price Increase: 2023-08-29
Automatic offers:

shubham1206agra | Contributor | 26488545

melvin-bot · 2023-08-22T14:39:24Z

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-22T14:39:25Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

akinwale · 2023-08-22T14:51:34Z

This looks like there is a long-running operation on the main thread which is blocking UI input for a few seconds before the tap to select a contact finally registers.

Christinadobrzyn · 2023-08-22T20:02:21Z

I can reproduce but this bug is inconsistent - but updated the OP to be as direct as possible on how to reproduce it. I think this can be External

melvin-bot · 2023-08-22T20:02:58Z

Job added to Upwork: https://www.upwork.com/jobs/~01198bfad5e1717772

melvin-bot · 2023-08-22T20:03:02Z

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-22T20:03:08Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

saalimzafar · 2023-08-22T21:55:22Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem at hand is the inability to select an assignee when tapping on any contact.

What is the root cause of that problem?

The root cause of this issue lies in the following code block:

// src/pages/tasks/TaskAssigneeSelectorModal.js
const [isLoading, setIsLoading] = React.useState(true);

const updateOptions = useCallback(() => {
    if (isLoading) {
        setIsLoading(false);
    }
  setIsLoading(true) // Update
}, [props, searchValue, isLoading]);

What changes do you think we should make in order to solve the problem?

To resolve this issue, I propose the following changes:

// src/pages/tasks/TaskAssigneeSelectorModal.js
const [isLoading, setIsLoading] = useState(false);

const updateOptions = useCallback(() => {
    if (!isLoading) {
        setIsLoading(true);
    }
}, [props, searchValue, isLoading]);

What alternative solutions did you explore? (Optional)

N/A

shubham1206agra · 2023-08-23T05:24:06Z

Unable to repro on DEV

robertKozik · 2023-08-23T11:52:20Z

@shubham1206agra It's reproducible on the latest main. I'm also attaching a video for reference.

Screen.Recording.2023-08-23.at.13.42.04.mov

@saalimzafar I don't think your suggested root cause is correct, and the same applies to the solution you provided. The isLoading state controls whether the option list is visible or not, and it's set before any user interaction with the list. You can find it here:

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Line 202 in 4f412db

shouldShowOptions={didScreenTransitionEnd && !isLoading}

Your proposed change would cause this screen to be stuck in the loading state, and only the skeleton of the components would be visible.

shubham1206agra · 2023-08-23T13:01:09Z

@robertKozik I was able to repro this only once. Then after that I am unable to repro the result

robertKozik · 2023-08-23T13:23:51Z

It appears that the issue is reproducible right after the task is created. If you navigate away from it and then return, it seems to work as intended.

shubham1206agra · 2023-08-23T13:26:21Z

@robertKozik Yeah
This helps thanks

shubham1206agra · 2023-08-23T17:01:42Z

Proposal

Please re-state the problem that we are trying to solve in this issue

Assign task-Tapping on any contact, user unable to select assignee

What is the root cause of that problem?

This is due to race condition between unmounting NewTaskPage (which calls to clear the contents of Task inside Onyx) and setting the report inside task Onyx after the API call (or optimistic onyx set of the report and maybe response too).
This problem will occur when

App/src/pages/tasks/NewTaskPage.js

Lines 100 to 108 in 43c6f11

    
           useEffect( 
        
               () => () => { 
        
                   if (!shouldClearOutTaskInfoOnUnmount.current) { 
        
                       return; 
        
                   } 
        
                   Task.clearOutTaskInfo(); 
        
               }, 
        
               [], 
        
           );

will execute after

App/src/components/ReportActionItem/TaskView.js

Lines 44 to 46 in 43c6f11

    
           useEffect(() => { 
        
               Task.setTaskReport({...props.report}); 
        
           }, [props.report]);

And props.report never changes after that in TaskView component.

What changes do you think we should make in order to solve the problem?

Call Task.clearOutTaskInfo before the API call in Task.createTaskAndNavigate and remove the useEffect logic.

Edit - It looks like the unmounting logic was introduced due to #23342. So, we would introduce the state variable for the title and description in NewTaskPage to fix this problem, just like assignee and shareDestination inside here.

App/src/pages/tasks/NewTaskPage.js

Lines 74 to 98 in 43c6f11

    
           useEffect(() => { 
        
               setErrorMessage(''); 
        
               // If we have an assignee, we want to set the assignee data 
        
               // If there's an issue with the assignee chosen, we want to notify the user 
        
               if (props.task.assignee) { 
        
                   const displayDetails = Task.getAssignee(props.task.assigneeAccountID, props.personalDetails); 
        
                   setAssignee(displayDetails); 
        
               } 
        
               // We only set the parentReportID if we are creating a task from a report 
        
               // this allows us to go ahead and set that report as the share destination 
        
               // and disable the share destination selector 
        
               if (props.task.parentReportID) { 
        
                   Task.setShareDestinationValue(props.task.parentReportID); 
        
               } 
        
               // If we have a share destination, we want to set the parent report and 
        
               // the share destination data 
        
               if (props.task.shareDestination) { 
        
                   setParentReport(lodashGet(props.reports, `report_${props.task.shareDestination}`, {})); 
        
                   const displayDetails = Task.getShareDestination(props.task.shareDestination, props.reports, props.personalDetails); 
        
                   setShareDestination(displayDetails); 
        
               } 
        
           }, [props]);

For example, not exact

if (!_.isUndefined(props.task.title)) {
    setTitle(props.task.title);
}

if (!_.isUndefined(props.task.description)) {
    setDescription(props.task.description);
}

And use state variable title and description instead of props.task.title, and props.task.description, respectively here.

App/src/pages/tasks/NewTaskPage.js

Lines 154 to 167 in 43c6f11

    
           <MenuItemWithTopDescription 
        
               description={props.translate('task.title')} 
        
               title={props.task.title || ''} 
        
               onPress={() => Navigation.navigate(ROUTES.NEW_TASK_TITLE)} 
        
               shouldShowRightIcon 
        
           /> 
        
           <MenuItemWithTopDescription 
        
               description={props.translate('task.description')} 
        
               title={props.task.description || ''} 
        
               onPress={() => Navigation.navigate(ROUTES.NEW_TASK_DESCRIPTION)} 
        
               shouldShowRightIcon 
        
               numberOfLinesTitle={2} 
        
               titleStyle={styles.flex1} 
        
           />

And it looks like something reverted the change from #23556.
Especially this change

- Task.editTaskAndNavigate(props.task.report, props.session.accountID, {
+ Task.editTaskAndNavigate(report, props.session.accountID, {

So, redoing this change might future-proof the problem.
Example

// Pass through the selected assignee
Task.editTaskAssigneeAndNavigate(report, props.session.accountID, option.login, option.accountID, assigneeChatReport);

What alternative solutions did you explore? (Optional)

Temporarily block the change in the task changes in Promise then mechanism when unmounting the NewTaskPage, and after unmounting, we can start resolving the changes (i.e. after calling of clearOutTaskInfo).

Examples of similar mechanisms can be found for Growl
https://github.com/Expensify/App/blob/43c6f11bd59b1d83ed4cef1162610f3e34aff701/src/libs/Growl.js

robertKozik · 2023-08-25T10:48:03Z

I cannot longer reproduce this issue on production environment, could you double-check on your end?

shubham1206agra · 2023-08-25T13:10:20Z

I cannot longer reproduce this issue on production environment, could you double-check on your end?

@robertKozik
It's really hard to repro the issue from the start cause it's a race condition which has special case

robertKozik · 2023-08-25T15:35:31Z

I got it, but beforehand (two days ago) I was able to reproduce it continuously. I'll try to repro it again and again

@shubham1206agra about your proposal - Root cause is propably correct (I'll confirm it as soon as I will be able to reproduce it). But using the simmilar machanism to Growl seems like an overkill there. Maybe we can try to extend the function Task.createTaskAndNavigate so it will synchronously invoke the Task.clearOutTaskInfo before executing navigation process? So we will no longer dependant only on component recycle method (returning the function from useEffect)

shubham1206agra · 2023-08-25T16:12:02Z

I got it, but beforehand (two days ago) I was able to reproduce it continuously. I'll try to repro it again and again

@shubham1206agra about your proposal - Root cause is propably correct (I'll confirm it as soon as I will be able to reproduce it). But using the simmilar machanism to Growl seems like an overkill there. Maybe we can try to extend the function Task.createTaskAndNavigate so it will synchronously invoke the Task.clearOutTaskInfo before executing navigation process? So we will no longer dependant only on component recycle method (returning the function from useEffect)

Ok
This will be easier ig

melvin-bot · 2023-09-04T12:25:53Z

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

cristipaval · 2023-09-04T12:26:17Z

Thanks @robertKozik !
@shubham1206agra , you're all set! 🚀

melvin-bot · 2023-09-12T21:39:27Z

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

when @shubham1206agra got assigned: 2023-09-04 12:25:53 Z
when the PR got merged: 2023-09-12 21:39:27 UTC
days elapsed: 6

On to the next one 🚀

melvin-bot · 2023-09-14T10:20:11Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-09-14T10:20:14Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fixed race condition in task creation and onyx #26692

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@shubham1206agra requires payment offer (Contributor)
@robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-14T10:20:16Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@robertKozik] Determine if we should create a regression test for this bug.
[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Christinadobrzyn · 2023-09-15T19:04:14Z

prepping for payment... @robertKozik should there be a regression test for this?

Christinadobrzyn · 2023-09-22T21:01:55Z

Also @cristipaval I see a merge freeze was involved in the PR merge, this might have affected the speed bonus. Do we think a speed bonus applies here?

cristipaval · 2023-09-24T21:23:55Z

Good point @Christinadobrzyn! Yes the speed bonus should apply, I checked the dates. I held the PR due to that merge freeze.

robertKozik · 2023-09-25T11:29:46Z

[@robertKozik] The PR that introduced the bug has been identified. Link to the PR: Fix: The title field is cleared when the Confirm task button is pressed #23342

[@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23342/files#r1335754275

[@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

[@robertKozik] Determine if we should create a regression test for this bug. I think we don't need regression test here. It's rather edge-case scenario, which can be fixed with re-accessing the screen.

[@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

CC. @Christinadobrzyn

Christinadobrzyn · 2023-09-26T00:19:59Z

Payouts due:

Issue Reporter: NA
Contributor: $1000 +500 bonus @shubham1206agra in Upwork
Contributor+: @robertKozik payment through contract

Eligible for 50% #urgency bonus? Yes - #25689 (comment)

Upwork job is here.

@robertKozik let us know about the regression test so we can get this closed out -thanks!

robertKozik · 2023-09-26T16:12:28Z

I don't think we need regression test for it #25689 (comment)

Christinadobrzyn · 2023-09-26T20:07:19Z

Ah sorry I missed that note about the regression test. Thanks for clarifying! Closing this out.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 22, 2023

melvin-bot bot assigned Christinadobrzyn Aug 22, 2023

Christinadobrzyn changed the title ~~Assign task-Tapping on any contact, user unable to select assignee~~ [Android] Assign task-Tapping on any contact, user unable to select assignee Aug 22, 2023

Christinadobrzyn added the Needs Reproduction Reproducible steps needed label Aug 22, 2023

Christinadobrzyn changed the title ~~[Android] Assign task-Tapping on any contact, user unable to select assignee~~ Assign task-Tapping on any contact, user unable to select assignee Aug 22, 2023

Christinadobrzyn removed the Needs Reproduction Reproducible steps needed label Aug 22, 2023

Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Aug 22, 2023

melvin-bot bot changed the title ~~Assign task-Tapping on any contact, user unable to select assignee~~ [$1000] Assign task-Tapping on any contact, user unable to select assignee Aug 22, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 22, 2023

melvin-bot bot assigned robertKozik Aug 22, 2023

melvin-bot bot added the Overdue label Aug 28, 2023

melvin-bot bot added the Overdue label Sep 4, 2023

cristipaval assigned shubham1206agra Sep 4, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 4, 2023

melvin-bot bot removed the Overdue label Sep 4, 2023

shubham1206agra mentioned this issue Sep 4, 2023

fixed race condition in task creation and onyx #26692

Merged

60 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 4, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 14, 2023

melvin-bot bot changed the title ~~[$1000] Assign task-Tapping on any contact, user unable to select assignee~~ [HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee Sep 14, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Sep 14, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 21, 2023

Christinadobrzyn closed this as completed Sep 26, 2023

bernhardoj mentioned this issue Oct 10, 2024

[HOLD for payment 2024-10-30] [$250] Assign task - Inconsistent Button Behavior Between Submit and Assign Task After Navigating via URL #50577

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689

[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689

lanitochka17 commented Aug 22, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023 •

edited by Christinadobrzyn

Loading

akinwale commented Aug 22, 2023

Christinadobrzyn commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

saalimzafar commented Aug 22, 2023 •

edited

Loading

shubham1206agra commented Aug 23, 2023

robertKozik commented Aug 23, 2023

shubham1206agra commented Aug 23, 2023

robertKozik commented Aug 23, 2023

shubham1206agra commented Aug 23, 2023

shubham1206agra commented Aug 23, 2023 •

edited

Loading

robertKozik commented Aug 25, 2023 •

edited

Loading

shubham1206agra commented Aug 25, 2023

robertKozik commented Aug 25, 2023

shubham1206agra commented Aug 25, 2023

melvin-bot bot commented Sep 4, 2023

cristipaval commented Sep 4, 2023

melvin-bot bot commented Sep 12, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023 •

edited by Christinadobrzyn

Loading

melvin-bot bot commented Sep 14, 2023

Christinadobrzyn commented Sep 15, 2023

Christinadobrzyn commented Sep 22, 2023

cristipaval commented Sep 24, 2023 •

edited

Loading

robertKozik commented Sep 25, 2023

Christinadobrzyn commented Sep 26, 2023

robertKozik commented Sep 26, 2023

Christinadobrzyn commented Sep 26, 2023

[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689

[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689

Comments

lanitochka17 commented Aug 22, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023 • edited by Christinadobrzyn Loading

Bug0 Triage Checklist (Main S/O)

akinwale commented Aug 22, 2023

Christinadobrzyn commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

saalimzafar commented Aug 22, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

shubham1206agra commented Aug 23, 2023

robertKozik commented Aug 23, 2023

shubham1206agra commented Aug 23, 2023

robertKozik commented Aug 23, 2023

shubham1206agra commented Aug 23, 2023

shubham1206agra commented Aug 23, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

robertKozik commented Aug 25, 2023 • edited Loading

shubham1206agra commented Aug 25, 2023

robertKozik commented Aug 25, 2023

shubham1206agra commented Aug 25, 2023

melvin-bot bot commented Sep 4, 2023

cristipaval commented Sep 4, 2023

melvin-bot bot commented Sep 12, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023 • edited by Christinadobrzyn Loading

melvin-bot bot commented Sep 14, 2023

Christinadobrzyn commented Sep 15, 2023

Christinadobrzyn commented Sep 22, 2023

cristipaval commented Sep 24, 2023 • edited Loading

robertKozik commented Sep 25, 2023

Christinadobrzyn commented Sep 26, 2023

robertKozik commented Sep 26, 2023

Christinadobrzyn commented Sep 26, 2023

lanitochka17 commented Aug 22, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 22, 2023 •

edited by Christinadobrzyn

Loading

saalimzafar commented Aug 22, 2023 •

edited

Loading

shubham1206agra commented Aug 23, 2023 •

edited

Loading

robertKozik commented Aug 25, 2023 •

edited

Loading

melvin-bot bot commented Sep 14, 2023 •

edited by Christinadobrzyn

Loading

cristipaval commented Sep 24, 2023 •

edited

Loading