[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

kavimuru · 2023-08-17T19:13:14Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

click "+" button
select request money
try to slide right to left

Expected Result:

selection change should be immediately

Actual Result:

selection change takes some time

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-16.at.5.42.59.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @niravkakadiya25
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691384151135339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010c514d8b4722d88a
Upwork Job ID: 1692452963606020096
Last Price Increase: 2023-08-18

melvin-bot · 2023-08-17T19:13:19Z

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-17T19:13:21Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

allroundexperts · 2023-08-17T22:55:34Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tab change not animating when screen is swiped when on MoneyRequestPage.

What is the root cause of that problem?

The root cause is that we're having static values as background colours for the buttons, icons and text inside the tab.

What changes do you think we should make in order to solve the problem?

We need to make use of the position property here and pass that onto the TabSelector component. Inside it, we need to interpolate this position value between:

Background colour of the button in selected / un-selected state.
Text colour of the button in selected / un-selected state.
Icon colour of the button in selected / un-selected state.

These interpolated values of colours are then to be used inside TabSelectorItem component. This will result in a smooth transition which will dispel the lag effect.

What alternative solutions did you explore? (Optional)

We can also just disable the swipe on web so that the user can only switch the tab by pressing the button itself. However, I think that the solution proposed above is more elegant.

melvin-bot · 2023-08-18T08:26:47Z

Job added to Upwork: https://www.upwork.com/jobs/~010c514d8b4722d88a

melvin-bot · 2023-08-18T08:26:50Z

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-18T08:26:55Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

greg-schroeder · 2023-08-18T08:27:02Z

I can't repro DEV issues - I'm assuming since you made a proposal here @allroundexperts that you were able to?

allroundexperts · 2023-08-18T09:48:45Z

Hi @greg-schroeder!

Yes, this is easily reproducible.

@shawnborton How should the animation look like here? Do you think animating the colours as the user slides the screen makes sense?

studentofcoding · 2023-08-18T10:05:15Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tab change animations are delayed when the screen is swiped when on MoneyRequestPage.

What is the root cause of that problem?

The root cause of this problem is that by default, React Navigation lazy loads tab screens, which means that the screens are only rendered when accessed for the first time. This can cause a delay in rendering the new tab screen when swiping.

When the screen is swiped, the new tab screen needs to be rendered immediately to provide a smooth transition. However, because of lazy loading, there is a delay in rendering the new tab screen, resulting in delayed animation.

What changes do you think we should make to solve the problem?

What we need to do is simply disable lazy by setting the lazy prop of the OnyxTabNavigator component to false in MoneyRequestSelectorPage.js. This ensures that all tab screens are rendered upfront, eliminating the delay in the tab change animation.

<OnyxTabNavigator
                                    lazy={false} // Add this line
                                    id={CONST.TAB.RECEIPT_TAB_ID}
                                    tabBar={({state, navigation}) => (
                                        <TabSelector
                                            state={state}
                                            navigation={navigation}
                                            onTabPress={resetMoneyRequestInfo}
                                        />
                                    )}
                                >
                                    <TopTab.Screen
                                        name={CONST.TAB.MANUAL}
                                        component={NewRequestAmountPage}
                                        initialParams={{reportID, iouType}}
                                    />
                                    {canUseScanReceipts && (
                                        <TopTab.Screen
                                            name={CONST.TAB.SCAN}
                                            component={ReceiptSelector}
                                            initialParams={{reportID, iouType}}
                                        />
                                    )}
                                    {canUseDistanceRequests && (
                                        <TopTab.Screen
                                            name={CONST.TAB.DISTANCE}
                                            component={DistanceRequestPage}
                                        />
                                    )}
                                </OnyxTabNavigator>

What alternative solutions did you explore? (Optional)

None

cc @greg-schroeder

shawnborton · 2023-08-18T12:28:25Z

This is not a bug, we can close. cc @AndrewGable

allroundexperts · 2023-08-18T12:30:22Z

@shawnborton Is there any specific reason why this is not a bug? The tabs are clearly getting stuck.

shawnborton · 2023-08-18T12:48:30Z

Based on the video the tabs don't look stuck. Looks like they slide in and out as intended.

allroundexperts · 2023-08-18T12:57:50Z

@shawnborton Please watch from 8s onwards.

shawnborton · 2023-08-18T13:04:58Z

It's really hard to tell because the mouse is moving like crazy in that video. Can we create a new video where the mouse is doing normal gestures?

allroundexperts · 2023-08-18T13:12:55Z

Here you go @shawnborton.

Screen.Recording.2023-08-18.at.6.12.19.PM.mov

shawnborton · 2023-08-18T13:17:04Z

Cool, thanks for that. Curious for @AndrewGable's thoughts here.

redpanda-bit · 2023-08-18T17:12:39Z

Proposal

Selection change between tab screens is not immediate due to not using realtime animation of tab active state.

Please re-state the problem that we are trying to solve in this issue.

Make tabs active state have a faster feedback between screen changes.

What is the root cause of that problem?

It takes about a second for react-navigation/material-top-tabs to update navigation state with the current active tab, this time is reflected in this UI lag.

What changes do you think we should make in order to solve the problem?

Instead of changing states based on isSelected use the position property to determine active state.

tabs_active_state.mov

What alternative solutions did you explore? (Optional)

I consider adding new animations a risk at the moment. There is an android crash in react native related to animations. If it is not urgent, this should wait for that bug to be fixed in react native first, otherwise fixing this could introduce a different bug.

greg-schroeder · 2023-08-19T01:16:46Z

going to wait on @AndrewGable's take before I take any action on this one like potentially closing or not

greg-schroeder · 2023-08-21T17:43:24Z

bump @AndrewGable

AndrewGable · 2023-08-21T17:46:31Z

Yes this is something that can be improved. I agree with it being a bug.

melvin-bot · 2023-08-31T22:39:03Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-08-31T22:39:06Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

feat: fix the janky request money tab swipe on web #26022

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@burczu does not require payment (Contractor)
@allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-08-31T22:39:08Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@burczu / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@burczu / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@burczu / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu / @allroundexperts] Determine if we should create a regression test for this bug.
[@burczu / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-09-01T22:59:54Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: animated value as any #26378

If no regressions arise, payment will be issued on 2023-09-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@burczu does not require payment (Contractor)
@allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-01T22:59:55Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@burczu / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@burczu / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@burczu / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu / @allroundexperts] Determine if we should create a regression test for this bug.
[@burczu / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

greg-schroeder · 2023-09-08T22:35:29Z

Processing payments

greg-schroeder · 2023-09-08T23:16:43Z

Was this issue merged in time to be eligible for the speed bonus? ❌
Were their any regressions? ❌

Payment summary:

Reporter: @niravkakadiya25 - $250
Contributor: @allroundexperts - $1000
C+: @burczu - $1000

greg-schroeder · 2023-09-08T23:21:44Z

Offer sent to @niravkakadiya25. @allroundexperts you can make a manual request. All that's left is the checklist.

allroundexperts · 2023-09-09T00:10:28Z

Requested.

JmillsExpensify · 2023-09-10T10:29:47Z

$1,000 payment approved via NewDot based on BZ summary.

greg-schroeder · 2023-09-12T14:17:33Z

Bump on the checklist @burczu and then we can close this out!

burczu · 2023-09-13T10:51:09Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@burczu / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR: this is not regression
[@burczu / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: -
[@burczu / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: -
[@burczu / @allroundexperts] Determine if we should create a regression test for this bug.
[@burczu / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-09-14T09:03:08Z

@burczu @greg-schroeder @allroundexperts @thienlnam this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

Decide whether any proposals currently meet our guidelines and can be approved as-is today
If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot · 2023-09-14T09:03:16Z

Current assignees @burczu and @allroundexperts are eligible for the Internal assigner, not assigning anyone new.

kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 17, 2023

melvin-bot bot assigned greg-schroeder Aug 17, 2023

greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Aug 18, 2023

melvin-bot bot changed the title ~~DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money~~ [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money Aug 18, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 18, 2023

melvin-bot bot assigned burczu Aug 18, 2023

melvin-bot bot added the Overdue label Aug 21, 2023

melvin-bot bot removed the Overdue label Aug 21, 2023

melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Aug 31, 2023

melvin-bot bot changed the title ~~[$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money~~ [HOLD for payment 2023-09-07] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money Aug 31, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Aug 31, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Sep 1, 2023

allroundexperts mentioned this issue Sep 3, 2023

[$1000] Request money - Tab does not update instantly when switching to different tab by swiping #24422

Closed

6 tasks

melvin-bot bot added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Weekly KSv2 External Added to denote the issue can be worked on by a contributor labels Sep 14, 2023

melvin-bot bot added the Overdue label Sep 18, 2023

burczu mentioned this issue Sep 18, 2023

[HOLD for payment 2023-10-27] [$500] Focus does not shift directly from "Manual" option to "Distance" option #27563

Closed

6 tasks

greg-schroeder closed this as completed Sep 18, 2023

melvin-bot bot removed the Overdue label Sep 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

kavimuru commented Aug 17, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 17, 2023

melvin-bot bot commented Aug 17, 2023 •

edited by greg-schroeder

Loading

allroundexperts commented Aug 17, 2023

melvin-bot bot commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

greg-schroeder commented Aug 18, 2023

allroundexperts commented Aug 18, 2023

studentofcoding commented Aug 18, 2023 •

edited

Loading

shawnborton commented Aug 18, 2023

allroundexperts commented Aug 18, 2023

shawnborton commented Aug 18, 2023

allroundexperts commented Aug 18, 2023 •

edited

Loading

shawnborton commented Aug 18, 2023

allroundexperts commented Aug 18, 2023

shawnborton commented Aug 18, 2023

redpanda-bit commented Aug 18, 2023

greg-schroeder commented Aug 19, 2023

greg-schroeder commented Aug 21, 2023

AndrewGable commented Aug 21, 2023

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Sep 1, 2023

melvin-bot bot commented Sep 1, 2023

greg-schroeder commented Sep 8, 2023

greg-schroeder commented Sep 8, 2023

greg-schroeder commented Sep 8, 2023

allroundexperts commented Sep 9, 2023

JmillsExpensify commented Sep 10, 2023

greg-schroeder commented Sep 12, 2023

burczu commented Sep 13, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

Comments

kavimuru commented Aug 17, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 17, 2023

melvin-bot bot commented Aug 17, 2023 • edited by greg-schroeder Loading

Bug0 Triage Checklist (Main S/O)

allroundexperts commented Aug 17, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

greg-schroeder commented Aug 18, 2023

allroundexperts commented Aug 18, 2023

studentofcoding commented Aug 18, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make to solve the problem?

What alternative solutions did you explore? (Optional)

shawnborton commented Aug 18, 2023

allroundexperts commented Aug 18, 2023

shawnborton commented Aug 18, 2023

allroundexperts commented Aug 18, 2023 • edited Loading

shawnborton commented Aug 18, 2023

allroundexperts commented Aug 18, 2023

shawnborton commented Aug 18, 2023

redpanda-bit commented Aug 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

greg-schroeder commented Aug 19, 2023

greg-schroeder commented Aug 21, 2023

AndrewGable commented Aug 21, 2023

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Aug 31, 2023

melvin-bot bot commented Sep 1, 2023

melvin-bot bot commented Sep 1, 2023

greg-schroeder commented Sep 8, 2023

greg-schroeder commented Sep 8, 2023

greg-schroeder commented Sep 8, 2023

allroundexperts commented Sep 9, 2023

JmillsExpensify commented Sep 10, 2023

greg-schroeder commented Sep 12, 2023

burczu commented Sep 13, 2023

melvin-bot bot commented Sep 14, 2023

melvin-bot bot commented Sep 14, 2023

kavimuru commented Aug 17, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 17, 2023 •

edited by greg-schroeder

Loading

studentofcoding commented Aug 18, 2023 •

edited

Loading

allroundexperts commented Aug 18, 2023 •

edited

Loading