Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-05] [$250] [TS migration] Migrate 'InvertedFlatList' component to TypeScript #25137

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 31 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/InvertedFlatList/index.js 6
src/components/InvertedFlatList/index.ios.js 3
src/components/InvertedFlatList/index.android.js 8
src/components/InvertedFlatList/BaseInvertedFlatList.js 6
src/components/InvertedFlatList/CellRendererComponent/index.ios.js 3
src/components/InvertedFlatList/CellRendererComponent/index.android.js 4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0141a85c8a8f2f0402
  • Upwork Job ID: 1736777306494427136
  • Last Price Increase: 2023-12-18
  • Automatic offers:
    • ishpaul777 | Contributor | 28064672
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed Not a priority labels Dec 18, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'InvertedFlatList' component to TypeScript [$500] [TS migration] Migrate 'InvertedFlatList' component to TypeScript Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0141a85c8a8f2f0402

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Dec 18, 2023
@mountiny mountiny changed the title [$500] [TS migration] Migrate 'InvertedFlatList' component to TypeScript [$250] [TS migration] Migrate 'InvertedFlatList' component to TypeScript Dec 18, 2023
Copy link
Author

melvin-bot bot commented Dec 18, 2023

⚠️ Failed to update price automatically. The BZ team member will need to update the price manually in Upwork.

@ishpaul777
Copy link
Contributor

would love to take it..

@lancer-spaid
Copy link

I would like to work on this

@abeebridwan
Copy link

abeebridwan commented Dec 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

[TS migration] Migrate 'InvertedFlatList' component to TypeScript

What is the root cause of that problem?

Migration

What changes do you think we should make in order to solve the problem?

We need to update these files using best practices using TS guide

https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md

What alternative solutions did you explore? (Optional)
NA

@ZhenjaHorbach

This comment was marked as outdated.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 19, 2023
@ishpaul777
Copy link
Contributor

ishpaul777 commented Dec 22, 2023

@rushatgabhane Can you review the PR when you get chance.. Thanks!

MonilBhavsar added a commit that referenced this issue Dec 28, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 29, 2023
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'InvertedFlatList' component to TypeScript [HOLD for payment 2024-01-05] [$250] [TS migration] Migrate 'InvertedFlatList' component to TypeScript Dec 29, 2023
Copy link
Author

melvin-bot bot commented Dec 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 29, 2023
Copy link
Author

melvin-bot bot commented Dec 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@rushatgabhane
Copy link
Member

@MonilBhavsar could you please add payment summary for this issue

@MonilBhavsar
Copy link
Contributor

From this comment, you're paid through newdot and @ishpaul777 is paid automatically through upwork contract. Is that right?

@ishpaul777
Copy link
Contributor

correct, Minor clarification:

@ishpaul777 is paid automatically through upwork contract

Someone from expensify should approve the payment and end contract manually

@MonilBhavsar
Copy link
Contributor

Thanks! I'll assign BZ team member then

@MonilBhavsar MonilBhavsar added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 8, 2024
Copy link
Author

melvin-bot bot commented Jan 8, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Author

melvin-bot bot commented Jan 8, 2024

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Jan 8, 2024

@alexpensify can you please accept @ishpaul777 's contract here, thank you!

@alexpensify
Copy link
Contributor

alexpensify commented Jan 8, 2024

Here is the payment summary:

  • External issue reporter - N/A
  • Contributor that fixed the issue - $250 @ishpaul777
  • Contributor+ that helped on the issue and/or PR - $250 @rushatgabhane

Upwork Job: https://www.upwork.com/jobs/~0141a85c8a8f2f0402

Extra Notes regarding payment: No

@alexpensify
Copy link
Contributor

Closing - the payment has been sent via Upwork.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Jan 8, 2024
@JmillsExpensify
Copy link

$250 approved for @rushatgabhane based on comment above.

@JmillsExpensify
Copy link

$250 payment approved for @rushatgabhane based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests