-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-05] [$250] [TS migration] Migrate 'InvertedFlatList' component to TypeScript #25137
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Job added to Upwork: https://www.upwork.com/jobs/~0141a85c8a8f2f0402 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
|
would love to take it.. |
I would like to work on this |
ProposalPlease re-state the problem that we are trying to solve in this issue.[TS migration] Migrate 'InvertedFlatList' component to TypeScript What is the root cause of that problem?Migration What changes do you think we should make in order to solve the problem?We need to update these files using best practices using TS guide https://github.com/Expensify/App/blob/main/contributingGuides/TS_STYLE.md What alternative solutions did you explore? (Optional) |
This comment was marked as outdated.
This comment was marked as outdated.
@rushatgabhane Can you review the PR when you get chance.. Thanks! |
TS migration InvertedList #25137
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-05. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
@MonilBhavsar could you please add payment summary for this issue |
From this comment, you're paid through newdot and @ishpaul777 is paid automatically through upwork contract. Is that right? |
correct, Minor clarification:
Someone from expensify should approve the payment and end contract manually |
Thanks! I'll assign BZ team member then |
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
@alexpensify can you please accept @ishpaul777 's contract here, thank you! |
Here is the payment summary:
Upwork Job: https://www.upwork.com/jobs/~0141a85c8a8f2f0402 Extra Notes regarding payment: No |
Closing - the payment has been sent via Upwork. |
$250 approved for @rushatgabhane based on comment above. |
$250 payment approved for @rushatgabhane based on comment above. |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: