-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-02] [HOLD for payment 2023-08-01] [$1000] Web - The first letter of the chat name is cut #22997
Comments
Triggered auto assignment to @CortneyOfstad ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Room settings authorization. What is the root cause of that problem?We don't check user permission when accessing room settings and its menu (room name, who can post, welcome message) via deeplink. What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)Currenty, I don't see anywhere to set notification preference for DM chats. If we need it in the future, we will show only notification item when navigating to DM chats settings. |
ProposalPlease re-state the problem that we are trying to solve in this issue.What is the root cause of that problem?The root cause is that we strip first letter of chat report name for all chats (rooms and ordinary chats) here: Lines 1207 to 1210 in 67bac9d
What changes do you think we should make in order to solve the problem?We can add a condition to check whether the first letter is "#" or not What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.The first character of the name is removed in the Room name input. What is the root cause of that problem?In the App/src/components/RoomNameInput/index.js Line 71 in 25c8ae5
However, this is not the case since it concerns a chat report. No check is currently in place to distinguish these situations. What changes do you think we should make in order to solve the problem?Option 1. Based on an empty value of Option 2. We should not be able to edit the "room name" in the first place, since it does not concern a room. Thus, in the Settings page, the Room name should be removed, renamed (for example: Chat name, with the name being the actual title, i.e. the participants) and/or made not clickable. What alternative solutions did you explore? (Option)N/A |
Job added to Upwork: https://www.upwork.com/jobs/~0196a1bf7800ad8925 |
Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik ( |
@robertKozik We have a couple of proposals already shared above — feel free to share your thoughts/comments/etc when you can 👍 |
📣 @med-lean! 📣
|
📣 @makiour! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@CortneyOfstad Sure thing, I'll try review existing proposals today Hi @makiour It's good to have you here, this issue doesn't have any proposal selected yet, so fell free to post your proposal as well. |
Thank you @robertKozik, I will put my proposal in a bit! Thanks for your interaction. |
ProposalPlease re-state the problem that we are trying to solve in this issue.When we try to check the settings page, and room name more specifically, we ran into cutting the first letter as you can see from the picture I provided: After testing it on my own account, it seems that it happens only at first time when we have a default value of Chat Report. What is the root cause of that problem?The root issue is coming from the first time we initiate creating a chat with a user. Mainly, if we check the network request with the onyxData, we can clearly see that once we change the room-name, the data is returned with a dash as you can see below: The issue happens exactly when we just create an account (having that first chat with concierge) or when initiating a chat with any other user. As you can see the response is different and it is static to "Chat Report" without including a #dash. Thus, the issue doesn't have to go with changing the logic of deleting the first letter as we are guaranteed that the room name includes a dash once it is changed as the validation and custom creation forces including the dash What changes do you think we should make in order to solve the problem?The change I suggest: Line 626 in 9004c39
Thus, we will be able to see the full name of the room when creating any chat with any user. What alternative solutions did you explore? (Optional)The alternative solution is to change the logic of eliminating the first letter, which will need to check if the input includes a dash and differentiating between the two cases. Also, if this solution is the one followed, we need also to keep it in mind whenever a room name convention has changed or when dealing with dashes. Still, this will also fix the issue! |
Thank you all for your proposals. I'll address each individually: @ginsuma - I appreciate your proposal the most as it addresses the issue with accessing the settings page. However, it does prevent accessing the settings page for policy expense chats, even though it can be accessed in the "normal" way, to ensure consistency between accessing the settings page from the app and from the deep link. Please consider if wrapping them in FullPageNotFoundView is the best solution. If you can address the problem with policy expense chats, it would be a strong contender. @alexxxwork - While your proposal should work fine, I believe it doesn't address the root cause of the problem. Trimming the first letter of the name is a workaround for accessing a screen that shouldn't be accessible for a particular chat. @samh-nl - The second option in your proposal is moving in the right direction as the room name changing page shouldn't be accessible for every type of chat. However, I don't think changing the trimming itself is necessary. If you could expand the second option to the proposal, it'll be taken under consideration @makiour - I don't think you correctly addressed the root of the problem since it doesn't only occur the first time the chat name value is default. The ability to change the room name should be limited for specific chats. Trimming works fine when it's applicable (when the screen can be accessed by clicking within the app). To summarize, most of the proposals focus on patching the trimming mechanism rather than addressing the root cause of the problem. We should concentrate on prohibiting access to the screen via the deep link, ensuring consistency with what can be accessed from within the app. @ginsuma's proposal is a strong contender if it can also handle the issue with policy expense chats, which his proposal introduces. |
Thank you for your comment @robertKozik Could you please mention any other cases when this happens as well? As the room name has a validation structure, it seems that we can never save without the dash whenever room it is changed. No matter if we limit changing room name or not, the trimming will always be fine. So the default value is the only one that serms to cause the issue. @alexxxwork, thank you for your like to the comment as well! Do you have anything to add here as I am unable to see another issue with room-name rather than that or the solution looks fine to you. Thank you so much Robert for your time and comment once again. Happy to take this discussion further. |
I understand your point, @makiour. Let me provide an example to illustrate the issue. In the case of a normal chat with one person, when you deep link to the settings page, it isn't aware of this type of chat and presents the user with the option to change the name, even though settings shouldn't be accessible. On the other hand, in a thread where the settings page is accessible by clicking within the app, deep linking won't cause this issue because the settings page handles the thread and doesn't present the option to change the name. These examples demonstrate that the problem lies in the settings page not properly handling all types of chats, rather than the trimming itself. Changing the name works fine for group chats, and patching the name trimming would be over-engineering in this case, as it's not a supported option for threads or normal chats. Considering these points, I would agree with the approach of fixing the trimming when the changing name field can be accessed through the normal flow of the app, but i think it's not. |
ProposalsUpdate |
Thanks @ginsuma for updating your proposal. Your proposal effectively addresses the root cause of the issue (also as first one states it correctly) by preventing deep linking to the settings page for chats where it shouldn't be accessible. I also like the idea of expand these checks to other settings pages too. Due to these reasons, I'd go with @ginsuma proposal 🎀 👀 🎀 C+ reviewed |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-01. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-02. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@robertKozik just bumping the check list above ^^ TIA! |
|
I'm heading OoO until 8/14 and since this requires payment tomorrow, so reassigning in the meantime. @alexxxwork — contract has been offered for reporting the issue |
Triggered auto assignment to @garrettmknight ( |
Bug0 Triage Checklist (Main S/O)
|
I guess the regression nullifies the bonus, but it might be worth asking in #bug-zero since I haven't seen this kind of thing happen before |
I'd agree that the regression nullifies the bonus. We want to reward quick, thorough work. Paying out now! |
Summarizing payouts for this issue: Issue reporter: @alexxxwork $250 paid via Upwork Upwork job here. |
Hey, want to just point out that I'm part of the external agency (Software Mansion) so I'm not eligible for payment |
Ah, nevermind then. Thanks for the heads up! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
he name should be the same as on previous page
Actual Result:
The first letter of the chat name is cut
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.40-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
2023-07-17.10.00.20.mov
Recording.3686.mp4
Expensify/Expensify Issue URL:
Issue reported by: @alexxxwork
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689405309465269
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: