[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers #22953

kbecciv · 2023-07-15T19:50:51Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Login with any account and open any chat.
Click on the avatar in the chat header to open the chat details RHP.
Click anywhere else to close it.
Press the video call icon in the chat header to open the popover.
Press the forward button in the browser.

Expected Result:

RHP should open and popover should close.

Actual Result:

Both RHP and popover are open.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.41-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-15.at.1.38.43.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: Sibtain Ali
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689367096915129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013464e806f5099ea9
Upwork Job ID: 1696143850157252608
Last Price Increase: 2023-09-04

The text was updated successfully, but these errors were encountered:

melvin-bot · 2023-07-15T19:50:56Z

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-15T19:50:58Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

ahmdshrif · 2023-07-15T20:09:46Z

Proposal

Please restate the problem that we are trying to solve in this issue.

The video chat menu does not hide when RHP is open.

What is the root cause of that problem?

We are not checking if the screen is focused on the VideoChatMenuActive and hiding it accordingly.

What changes do you think we should make in order to solve the problem?

We will need to determine if the screen is focused or not using the withNavigationFocus HOC or useNavigationFocus hook. Then, we can create a hook to trigger when isFocused changes. If the screen is not focused, we will hide the menu. The code can be implemented as shown below:

const propTypes = {
    ...
    ...withNavigationFocusPropTypes,
};

...

useEffect(() => {
    if (props.isFocused) {
        return;
    }
    setIsVideoChatMenuActive(false);
}, [props.isFocused]);

...

export default compose(withWindowDimensions, withLocalize, withNavigationFocus)(BaseVideoChatButtonAndMenu);

What alternative solutions did you explore? (Optional)

Another alternative solution is to use useNavigation change and check if the current route is not our route. If it's not our route, we can hide the call menu.

allroundexperts · 2023-07-15T20:14:42Z

I think this should be held on #15289.

NicMendonca · 2023-07-26T20:23:19Z

still holding

NicMendonca · 2023-08-08T12:53:16Z

^ PR almost merged 🎉

NicMendonca · 2023-08-22T15:07:57Z

#15289 is closed! removing hold

melvin-bot · 2023-08-28T12:53:03Z

Job added to Upwork: https://www.upwork.com/jobs/~013464e806f5099ea9

allroundexperts · 2023-09-14T15:08:59Z

PR created @sobitneupane #27452

sophiepintoraetz · 2023-09-15T05:37:16Z

@Pluto0104 - we had an internal discussion and decided this was the best approach. Additionally, Sibtain had volunteered first. Ultimately, we as the BZ programme managers have final say as to what happens, thanks!

aimane-chnaif · 2023-09-19T17:47:05Z

It seems solution applied in PR is still not general.
Isn't it supposed to fix this case as well?

Repro step:

Open any chat
Switch to any other chat
Click browser back button
Hover any message and click Delete icon
Verify that Delete modal shows
Click browser forward button
Click browser back button

Happens on staging v1.3.71-7:

Screen.Recording.2023-09-19.at.6.11.37.PM.mov

allroundexperts · 2023-09-19T17:50:21Z

@aimane-chnaif This ticket was about popovers. The dialog above is a modal. I think the two are different.

melvin-bot · 2023-09-20T08:06:17Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-09-20T08:06:21Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: close popover when history is changed #27452

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@sobitneupane does not require payment (Eligible for Manual Requests)
@allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-20T08:06:23Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane / @allroundexperts] Determine if we should create a regression test for this bug.
[@sobitneupane / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

sobitneupane · 2023-09-25T04:01:58Z

@allroundexperts Since you have worked on the functionality, do you have idea which PR caused this issue?

allroundexperts · 2023-09-25T04:03:24Z

@sobitneupane I'm not sure if any PR has caused this. This seemed to be an edge case which existed even before the refactor we did around popovers!

sobitneupane · 2023-09-25T04:06:08Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:

Edge case that is present from long time.

[@sobitneupane / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

[@sobitneupane / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

[@sobitneupane / @allroundexperts] Determine if we should create a regression test for this bug.

Yes.

[@sobitneupane / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#22953 (comment)

sobitneupane · 2023-09-25T04:06:27Z

Regression Test Proposal

Log in to the app and click on the user avatar to open the RHP.
Click anywhere else to close it.
Open any popover.
Press the forward button in the browser.
Verify that the popover disappears.

dangrous · 2023-09-27T07:05:21Z

I might just update #3 to give some options of popovers, to make it easy. Otherwise looks good!

NicMendonca · 2023-09-27T14:19:29Z

reporter AND contributor: @allroundexperts: $1800 (reporting + fixing + speed + bonus for reporting AND fixing lol)
C+: @sobitneupane: $1,500 (pr review + speed)

@allroundexperts @sobitneupane don't forget to request payment via Expensify please!

NicMendonca · 2023-09-27T14:34:11Z

all set here, thanks everyone!

JmillsExpensify · 2023-10-05T13:21:06Z

$1,800 payment approved for @allroundexperts based on BZ summary.

sobitneupane · 2023-10-09T08:38:38Z

#22953 (comment)

Requested payment on newDot

JmillsExpensify · 2023-10-09T17:33:24Z

$1,500 payment approved fro @sobitneupane based on BZ summary.

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 15, 2023

melvin-bot bot assigned NicMendonca Jul 15, 2023

melvin-bot bot added the Overdue label Jul 17, 2023

NicMendonca changed the title ~~Web - RHP overlapping with the popovers~~ [Hold for #15289] Web - RHP overlapping with the popovers Jul 18, 2023

NicMendonca added Weekly KSv2 and removed Daily KSv2 labels Jul 18, 2023

melvin-bot bot removed the Overdue label Jul 18, 2023

melvin-bot bot added the Overdue label Jul 26, 2023

melvin-bot bot removed the Overdue label Jul 26, 2023

melvin-bot bot added the Overdue label Aug 3, 2023

melvin-bot bot removed the Overdue label Aug 8, 2023

melvin-bot bot added the Overdue label Aug 21, 2023

melvin-bot bot removed the Overdue label Aug 22, 2023

NicMendonca changed the title ~~[Hold for #15289] Web - RHP overlapping with the popovers~~ Web - RHP overlapping with the popovers Aug 22, 2023

NicMendonca added Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 and removed Weekly KSv2 labels Aug 28, 2023

melvin-bot bot added the Overdue label Aug 28, 2023

NicMendonca added External Added to denote the issue can be worked on by a contributor and removed Overdue labels Aug 28, 2023

melvin-bot bot changed the title ~~Web - RHP overlapping with the popovers~~ [$1000] Web - RHP overlapping with the popovers Aug 28, 2023

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 14, 2023

aimane-chnaif mentioned this issue Sep 19, 2023

[CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798

Merged

59 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 20, 2023

melvin-bot bot changed the title ~~[$1000] Web - RHP overlapping with the popovers~~ [HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers Sep 20, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Sep 20, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 26, 2023

NicMendonca closed this as completed Sep 27, 2023

hungvu193 mentioned this issue Jul 21, 2024

[HOLD for payment 2024-08-07] [$250] mweb - Hold - Interstitial modal "Got it" is auto-dismissed when hold expense #44082

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers #22953

[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers #22953

kbecciv commented Jul 15, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 15, 2023

melvin-bot bot commented Jul 15, 2023

ahmdshrif commented Jul 15, 2023 •

edited

Loading

allroundexperts commented Jul 15, 2023

NicMendonca commented Jul 26, 2023

NicMendonca commented Aug 8, 2023

NicMendonca commented Aug 22, 2023

melvin-bot bot commented Aug 28, 2023

allroundexperts commented Sep 14, 2023

sophiepintoraetz commented Sep 15, 2023

aimane-chnaif commented Sep 19, 2023

allroundexperts commented Sep 19, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

sobitneupane commented Sep 25, 2023

allroundexperts commented Sep 25, 2023

sobitneupane commented Sep 25, 2023 •

edited

Loading

sobitneupane commented Sep 25, 2023

dangrous commented Sep 27, 2023

NicMendonca commented Sep 27, 2023

NicMendonca commented Sep 27, 2023

JmillsExpensify commented Oct 5, 2023

sobitneupane commented Oct 9, 2023

JmillsExpensify commented Oct 9, 2023

[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers #22953

[HOLD for payment 2023-09-27] [$1000] Web - RHP overlapping with the popovers #22953

Comments

kbecciv commented Jul 15, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 15, 2023

melvin-bot bot commented Jul 15, 2023

Bug0 Triage Checklist (Main S/O)

ahmdshrif commented Jul 15, 2023 • edited Loading

Proposal

Please restate the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allroundexperts commented Jul 15, 2023

NicMendonca commented Jul 26, 2023

NicMendonca commented Aug 8, 2023

NicMendonca commented Aug 22, 2023

melvin-bot bot commented Aug 28, 2023

allroundexperts commented Sep 14, 2023

sophiepintoraetz commented Sep 15, 2023

aimane-chnaif commented Sep 19, 2023

allroundexperts commented Sep 19, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

sobitneupane commented Sep 25, 2023

allroundexperts commented Sep 25, 2023

sobitneupane commented Sep 25, 2023 • edited Loading

sobitneupane commented Sep 25, 2023

dangrous commented Sep 27, 2023

NicMendonca commented Sep 27, 2023

NicMendonca commented Sep 27, 2023

JmillsExpensify commented Oct 5, 2023

sobitneupane commented Oct 9, 2023

JmillsExpensify commented Oct 9, 2023

kbecciv commented Jul 15, 2023 •

edited by melvin-bot bot

Loading

ahmdshrif commented Jul 15, 2023 •

edited

Loading

sobitneupane commented Sep 25, 2023 •

edited

Loading