-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-07] [$1000] Workspace - Workspace icons are aligned to the left #22632
Comments
Triggered auto assignment to @slafortune ( |
Bug0 Triage Checklist (Main S/O)
|
I already commented on the offending PR with suggested changes. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace icons are not aligned properly What is the root cause of that problem?We are using Line 906 in 702d8e2
Line 923 in 702d8e2
Also, currently, we are calculating the width, as a workaround, which is also a part of the problem in this issue.
App/src/components/MultipleAvatars.js Lines 138 to 144 in 702d8e2
What changes do you think we should make in order to solve the problem?Use // in getHorizontalStackedAvatarStyle
- left: -(overlapSize * index)
+ marginLeft: index > 0 ? -overlapSize : 0
// in getHorizontalStackedOverlayAvatarStyle
- left: -(oneAvatarSize.width * 2 + oneAvatarBorderWidth * 2)
+ marginLeft: -(oneAvatarSize.width + oneAvatarBorderWidth * 2) We should also need to remove the width, as we don't need it anymore, because this proposal also removes the need for the workaround as it fixes the issue in the root, and removing it may prevent future issues like this. App/src/components/MultipleAvatars.js Lines 138 to 144 in 702d8e2
Screenshots |
Job added to Upwork: https://www.upwork.com/jobs/~01979666a980f0a661 |
Current assignee @slafortune is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Avatars group on final screen moves to the left if admin invites more 8 users. What is the root cause of that problem?If invited more than 8 users, they will be displayed in two rows, and each row's size is calculated as below. App/src/components/MultipleAvatars.js Lines 88 to 96 in 702d8e2
The width of the avatar row is calculated as follows. App/src/components/MultipleAvatars.js Lines 136 to 145 in 702d8e2
If an avatar row has more than the number of avatars in App/src/components/MultipleAvatars.js Lines 156 to 161 in 702d8e2
App/src/components/MultipleAvatars.js Lines 186 to 190 in 702d8e2
When there are more than 8 avatars invited, What changes do you think we should make in order to solve the problem?Avatar row's width should be equal to or less than - const length = avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length;
+ const length = Math.min(avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length, props.maxAvatarsInRow); What alternative solutions did you explore? (Optional)None. |
Thanks for the proposal everyone. @StevenKKC Your proposal looks good to me. But can you please add more explanation in your proposal. You have added two code blocks in the Root Cause Analysis. Can you please explain what are the things being calculated? What is the cause of issue? And how your solution solves the issue. Please update your proposal and let me know. |
@sobitneupane I had already proposed solution directly in offending PR, with improvement - https://github.com/Expensify/App/pull/22595/files#r1259273320. Re-posting formal proposal here: Please re-state the problem that we are trying to solve in this issue.Workspace icons have wrong container width when count is more than 4 What is the root cause of that problem?The root cause is that while my original proposed solution to fix #22445 was being implemented in PR, missed the case of Let me explain with example:
What changes do you think we should make in order to solve the problem?update avatar rows max length logic here to not exceed |
@sobitneupane I have updated my proposal. Thanks. |
ProposalPlease re-state the problem that we are trying to solve in this issue.We want workspace icons to be aligned to right. What is the root cause of that problem?We do a different kind of width calculation when there are more than 4 icons, but at a single time we only display 4 icons. The extra width moves the icons to left. App/src/components/MultipleAvatars.js Lines 142 to 145 in 6e5b07c
What changes do you think we should make in order to solve the problem?We should update the width calculation here. Since we only display a max of 4 icons, we can remove the length calculation and use 4 directly (which comes from const length = Math.min(props.maxAvatarsInRow, props.icons.length)
width = oneAvatarSize.width + overlapSize * 2 * (length - 1) + oneAvatarBorderWidth * (length * 2); ![]() ![]() What alternative solutions did you explore? (Optional)N/A |
Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Hi @sobitneupane, please check my proposal also. @puneetlath and @abdulrahuman5196 please have a look here. |
@sobitneupane did you had a chance to review my proposal here? We actually don't have to calculate the length for different cases (i.e avatar > 4 or < 4) |
📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($1000) |
📣 @DrLoopFall 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @bernhardoj We're missing your Upwork ID to automatically send you an offer for the Reporter role. |
@sobitneupane @Li357 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-07. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Merged PR within 3 business days of assignment - 50% bonus
|
@DrLoopFall what is your Upworks profile? I am unable to find you or a name associated with your GH profile. Thanks! |
This should have been caught in PR test.
Yes.
|
Regression test Proposal:
Do we agree 👍 or 👎 |
Requested payment on newDot. |
Reviewed the details for @sobitneupane. $1,500 approved for payment in NewDot. |
Regression test - https://github.com/Expensify/Expensify/issues/307568 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The workspace icons should be aligned to the right
Actual Result:
Workspace icons are aligned to the left
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20230711_065833_Chrome.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689050547642229
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: