[HOLD for payment 2023-07-21] [$1000] Action menu has cursor pointer while it is not clickable

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report
2. Chat any message
3. Hover on message, Observe the action menu pops up
4. Move the mouse pointer to the space between two action menus Observe that it has a pointer but can't click

Expected Result:

The space between two action menus should not be a pointer because it cannot be clicked

Actual Result:

mouse pointer to the space between two action menus has a pointer and but can't click

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-05.at.16.52.01.mov

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688551149538179

View all open jobs on GitHub

Recording.1178.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01433188c964925d3e
• Upwork Job ID: 1676883396553637888
• Last Price Increase: 2023-07-06

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Action menu has cursor pointer while it is not clickable.

What is the root cause of that problem?

There is no cursor style added to MiniReportActionContextMenu, and it inherits parent cursor style pointer

What changes do you think we should make in order to solve the problem?

we need to add cursor style styles.cursorDefault here.

App/src/styles/StyleUtils.js

Lines 647 to 654 in d2de779

	function getMiniReportActionContextMenuWrapperStyle(isReportActionItemGrouped) {
	return {
	...(isReportActionItemGrouped ? positioning.tn8 : positioning.tn4),
	...positioning.r4,
	position: 'absolute',
	zIndex: 1,
	};
	}

What alternative solutions did you explore? (Optional)

instead we can to add cursor style styles.cursorDefault to BaseReportActionContextMenu container view here.

style={[this.wrapperStyle, styles.cursorDefault]}

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mini context menu shows cursor pointer around the item even though it's actually not clickable.

What is the root cause of that problem?

This issue starts to happen after the accessible pressable project. In GenericPressable, we are setting the cursor to pointer by default.

App/src/components/Pressable/GenericPressable/BaseGenericPressable.js

Line 146 in 4f9f428

getCursorStyle(shouldUseDisabledCursor, [props.accessibilityRole, props.role].includes('text')),

App/src/components/Pressable/GenericPressable/BaseGenericPressable.js

Lines 18 to 28 in 4f9f428

	const getCursorStyle = (isDisabled, isText) => {
	if (isDisabled) {
	return styles.cursorDisabled;
	}
	if (isText) {
	return styles.cursorText;
	}
	return styles.cursorPointer;
	};

This is assuming that every component that use Pressable will be clickable, but it's not the case with this issue.

In this issue, the whole mini context menu cursor becomes pointer because it inherits the cursor style from PressableWithSecondaryInteraction.

App/src/pages/home/report/ReportActionItem.js

Lines 439 to 461 in 4f9f428

	<PressableWithSecondaryInteraction
	pointerEvents={props.action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? 'none' : 'auto'}
	ref={popoverAnchorRef}
	onPressIn={() => props.isSmallScreenWidth && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
	onPressOut={() => ControlSelection.unblock()}
	onSecondaryInteraction={showPopover}
	preventDefaultContextMenu={!props.draftMessage && !hasErrors}
	withoutFocusOnSecondaryInteraction
	accessibilityLabel={props.translate('accessibilityHints.chatMessage')}
	>
	<Hoverable disabled={Boolean(props.draftMessage)}>
	{(hovered) => (
	<View>
	{props.shouldDisplayNewMarker && <UnreadActionIndicator reportActionID={props.action.reportActionID} />}
	<MiniReportActionContextMenu
	reportID={props.report.reportID}
	reportAction={props.action}
	isArchivedRoom={ReportUtils.isArchivedRoom(props.report)}
	displayAsGroup={props.displayAsGroup}
	isVisible={hovered && !props.draftMessage && !hasErrors}
	draftMessage={props.draftMessage}
	isChronosReport={ReportUtils.chatIncludesChronos(props.report)}
	/>

PressableWithSecondaryInteraction is based on PressableWithFeedback which is based on GenericPressable. We don't set any onPress here, so the cursor style shouldn't be a pointer.

What changes do you think we should make in order to solve the problem?

The easiest fix is to set the cursor style here as default. styles.cursorDefault

App/src/pages/home/report/ReportActionItem.js

Lines 439 to 461 in 4f9f428

	<PressableWithSecondaryInteraction
	pointerEvents={props.action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? 'none' : 'auto'}
	ref={popoverAnchorRef}
	onPressIn={() => props.isSmallScreenWidth && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
	onPressOut={() => ControlSelection.unblock()}
	onSecondaryInteraction={showPopover}
	preventDefaultContextMenu={!props.draftMessage && !hasErrors}
	withoutFocusOnSecondaryInteraction
	accessibilityLabel={props.translate('accessibilityHints.chatMessage')}
	>
	<Hoverable disabled={Boolean(props.draftMessage)}>
	{(hovered) => (
	<View>
	{props.shouldDisplayNewMarker && <UnreadActionIndicator reportActionID={props.action.reportActionID} />}
	<MiniReportActionContextMenu
	reportID={props.report.reportID}
	reportAction={props.action}
	isArchivedRoom={ReportUtils.isArchivedRoom(props.report)}
	displayAsGroup={props.displayAsGroup}
	isVisible={hovered && !props.draftMessage && !hasErrors}
	draftMessage={props.draftMessage}
	isChronosReport={ReportUtils.chatIncludesChronos(props.report)}
	/>

What alternative solutions did you explore? (Optional)

If a pressable doesn't have an onPress props, we should not change the cursor style.

[twisterdotcom]

Very niche, but it is a bug I suppose.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01433188c964925d3e

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

📣 @thesahindia 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @namhihi237 We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[twisterdotcom]

OH FFS. I was just trying to get this done before I go OOO and GH unassigned everybody.

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Action menu has cursor pointer while it is not clickable.

What is the root cause of that problem?

There is no cursor style added to getMiniReportActionContextMenuWrapperStyle of MiniReportActionContextMenu.
So The cursor is pointer by default.

What changes do you think we should make in order to solve the problem?

I think we can add ...styles.cursorDefault to getMiniReportActionContextMenuWrapperStyle.

What alternative solutions did you explore? (Optional)

[thesahindia]

@ahmedGaber93's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

📣 @thesahindia 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @namhihi237 We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[ahmedGaber93]

@thesahindia PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add styles.cursorDefault to mini context menu. #22686

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

@ahmedGaber93 - paid https://www.upwork.com/en-gb/nx/wm/workroom/34196455/overview?milestone=30845003.
@thesahindia - you should request payment in newDot and complete the BZ checklist.
@namhihi237 - I still need you to apply for your $250: Upwork job

[namhihi237]

@twisterdotcom applied

[ahmedGaber93]

Thanks! @twisterdotcom
But i think this issue is eligible for bounty.

[thesahindia]

you should request payment in newDot and complete the BZ checklist.

Yeah I will soon request the payment.

I believe we don't need any regression tests for this and it was a case that we missed and I couldn't find the PR that should have prevented this issue.

[twisterdotcom]

@ahmedGaber93 - paid $1500 https://www.upwork.com/en-gb/nx/wm/workroom/34196455/overview?milestone=30845003.
@thesahindia - you should request payment in newDot and complete the BZ checklist for $1500
@namhihi237 - Offer sent for $250: https://www.upwork.com/en-gb/nx/wm/offer/25751003

[namhihi237]

Acceptd @twisterdotcom

[namhihi237]

Hi @twisterdotcom I see the ticket is closed, So any updated payment for this?

[twisterdotcom]

Sorry, this was in my upwork inbox. Just got to it now. All done!

[namhihi237]

Thanks @twisterdotcom

[JmillsExpensify]

$1,500 payment for @thesahindia approved based on BZ summary.