[HOLD for payment 2023-08-07] [$1000] Android - Copy icon is not aligned with other texts

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App on Android phone
2. Click on avatar to open settings menu > Profile > Contact methods

Expected Result:

Copy icon should get aligned with other texts (like on iOS)

Actual Result:

Copy icon is not aligned with other texts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

XRecorder_04072023_133149.mp4

Expensify/Expensify Issue URL:
Issue reported by: @muxriddinmuqimov77
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688470298151389

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01294f4a678e2bc1c2
• Upwork Job ID: 1678413644500803584
2023-07-17
• Automatic offers:
• | | 0
• | | 0
• | | 0

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[DrLoopFall]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy icon is not aligned with the text

What is the root cause of that problem?

The inline property was missing from the Icon (was missed in this commit 152daf1).

What changes do you think we should make in order to solve the problem?

Just adding inline={props.inline} to Icon in PressableWithDelayToggle/index.js would fix the issue.

<Icon
+   inline={props.inline}
    ...
/>

[DrLoopFall]

Also, I think the icon size should be based on the device pixel ratio.

[conorpendergrast]

Ah yikes, I missed this on Wednesday, sorry! Reviewing now

[conorpendergrast]

Yeah you can see on Android the verticle alignment is slightly higher, and it's bumping against the text in the line above

Android	iOS

@Expensify/design Any desired outcome here?

[shawnborton]

The iOS style would be the desired outcome.

[conorpendergrast]

Nice, thanks Shawn

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01294f4a678e2bc1c2

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[umair-outlier]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The copy icon is not aligned with the text on android OS on contact method page

What is the root cause of that problem?

Icon is given a absolute position with value of top: 2, that is why icon is not appearing in line with the text and slightly hovers above

What changes do you think we should make in order to solve the problem?

we should change top: 2 to top: 3 in IconWrapperStyles -> index.js I propose this solution because this file is only used in one component, which is in question right now so changing this file won't have affect on other areas, also it is the most simple change as well.

• Tested on IOS - Simulator Iphone 14
• Tested on Android - Emulator Google Pixel
• Tested on Android - real device - Samsung A52

Before:

After:

What alternative solutions did you explore? (Optional)

• I explored drilling down styles to get the icon in line
• alternative solution I explored was to pass in additionalStyles prop to icon component as it accepts it already

Additionally found a small issue: we provide style prop to Icon component, but Icon component does not make use of props.style anywhere, instead it uses props.additionalStyles so we can remove this style prop from here

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @umair-outlier! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[umair-outlier]

Contributor details
Your Expensify account email: umairahmedbajwa97@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ef6da402835a55e6

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@conorpendergrast, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rushatgabhane]

Woah. All proposals are different. This is interesting!

[melvin-bot]

📣 @DrLoopFall You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @muxriddinmuqimov77 We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[DrLoopFall]

Hi @rushatgabhane and @hayata-suenaga,
While implementing the solution, I looked deeper and found the real root cause of the problem, the inline property was missing from the Icon (looks like it was somehow missed in this commit 152daf1).

So just adding inline={props.inline}, would solve the issue.
Also, we can't remove the top, we have to retain it, sorry for the confusion earlier.

I've updated my proposal accordingly, and have checked in all the supported platforms, it just works totally fine.
If you think the solution is good, I can make a PR now.

[DrLoopFall]

Thank you,
I've made PR #23541, and it's ready for review.

[melvin-bot]

🎯 ⚡️ Woah @rushatgabhane / @DrLoopFall, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @DrLoopFall got assigned: 2023-07-24 16:14:40 Z
• when the PR got merged: 2023-07-26 19:36:26 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix copy icon alignment #23541

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligable for Manual Requests)
• @DrLoopFall requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[conorpendergrast]

@DrLoopFall Could you please confirm your Upwork profile URL?

@muxriddinmuqimov77 Please could you apply to this Upwork job to make sure you get paid the bug bounty?

[muxriddinmuqimov77]

https://github.com/conorpendergrast I applied for a Job on Upwork

…

On Wednesday, August 2, 2023, Conor Pendergrast ***@***.***> wrote: @DrLoopFall <https://github.com/DrLoopFall> Could you please confirm your Upwork profile URL? @muxriddinmuqimov77 <https://github.com/muxriddinmuqimov77> Please could you apply to this Upwork job <https://www.upwork.com/jobs/~01294f4a678e2bc1c2> to make sure you get paid the bug bounty? — Reply to this email directly, view it on GitHub <#22259 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYFDM5MYC76CJVNW3HPOKY3XTJU5DANCNFSM6AAAAAAZ62LVMA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: feat: use pressable with press feedback #19391

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: feat: use pressable with press feedback #19391 (comment)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required we forgot to pass a prop and should have been caught in the code review.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Created a manual request - https://staging.new.expensify.com/r/8613046851814433

[conorpendergrast]

Payouts due:

• Issue Reporter: $250 @muxriddinmuqimov77
• Contributor: $1000 + 50% urgency bonus @DrLoopFall
• Contributor+: $1000 + 50% urgency bonus @rushatgabhane via NewDot

Eligible for 50% #urgency bonus? Yes

Upwork job is here.

[conorpendergrast]

All done and closing out. Thanks!

[JmillsExpensify]

Reviewed the payment details for @rushatgabhane. This is approved for payment on NewDot.