[HOLD for payment 2023-08-28] [$1000] [Manual Requests] Refactor usages of action.originalMessage to the transactions key in Onyx

[luacmartins]

Problem

We are now storing the transactions key in Onyx and should no longer use action.originalMessage.<amount|comment|date|etc>.

Why is this important?

Avoids data duplication and keeps the codebase clean and less confusing

Solution

Refactor the code!

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f38a35df644bdf5
• Upwork Job ID: 1676296881515593728
• Last Price Increase: 2023-07-05

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[luacmartins]

This is purely a code refactor and doesn't touch any design. So I'm gonna unassign @shawnborton.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f38a35df644bdf5

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[kowczarz]

Hello! I'm from Software Mansion, I'd like to work on this job.

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

[kowczarz]

Am I correct and the scope of the task is only src/libs/actions/Report.js or should I do it in all actions? And where can I find more docs about the new convention?

[luacmartins]

Hey @kowczarz. No, the scope is the entire App. We want to eventually deprecate originalMessage.

[luacmartins]

What docs are you looking for? The data currently found in originalMessage should be available in the new transactions key

[luacmartins]

Got a draft PR up. Will finish once the related Edit IOU PR is merged.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate reportAction.originalMessage to transactions #24345

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sebryu does not require payment (Contractor)
• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[luacmartins]

We're over the regression period. I see that nobody requires payment here, so I'm gonna close this issue. Please let me know if I missed something and we need to reopen this issue.

@sebryu does not require payment (Contractor)
@sobitneupane does not require payment (Eligible for Manual Requests)

[mountiny]

@sobitneupane @adelekennedy I think we still need to post the summarizing post for what the payments for Manual requests will be

[adelekennedy]

double check me @mountiny - only @sobitneupane is due for the internal PR review, is that correct?

[luacmartins]

that sounds correct to me

[adelekennedy]

Payouts due:

Contributor+: $500 for internal PR review @sobitneupane. NewDot

[sobitneupane]

Requested payment on newDot

#22208 (comment)

[JmillsExpensify]

$500 approved for payment via NewDot based on BZ summary.