[HOLD for payment 2023-07-05] [$1000] Workspace Chat (policyExpenseChat) not appearing in the OptionsList despite being on the beta

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. add a user/domain to the policyExpenseChat beta to be able to access the workspace chats
2. create a workspace
3. Observe the workspace chat appear in the LHN
4. Click CMD+F, observe the workspace chat does not appear in Search
5. Click the global create FAB icon (+) > request money > enter an amount > next, observe the workspace chat does not appear in the participant selector to send a money request to

Expected Result:

If you have access to the policyExpenseChat beta, workspace chats should appear in the OptionsList for Search and Request Money

Actual Result:

workspace chats do not appear in the OptionsList despite being on the beta.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**v1.3.30-5
Reproducible in staging?: Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Internal
Slack conversation: https://expensify.slack.com/archives/C02HWMSMZEC/p1687387646541889

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018148f6b7ca13d5ea
• Upwork Job ID: 1671873927259742208
• Last Price Increase: 2023-06-22

[melvin-bot]

📣 @fedirjh You have been assigned to this job by @trjExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018148f6b7ca13d5ea

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

[MonilBhavsar]

Dupe of #21283
This should be fixed by Migration

[fedirjh]

@MonilBhavsar Can you link the PR ?

[trjExpensify]

Is the fix for this going to collapsed into this #21283?

[fedirjh]

Is the fix for this going to collapsed into this #21283?

@trjExpensify Sorry I missed your comment. I raised a PR that will fix this bug , it's unrelated to the other issue.

[melvin-bot]

🎯 ⚡️ Woah @fedirjh / @fedirjh, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @fedirjh got assigned: 2023-06-22 13:33:00 Z
• when the PR got merged: 2023-06-26 16:19:06 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix] OptionListUtils.getOptions is filtering workspaces chats #21357

If no regressions arise, payment will be issued on 2023-07-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

#21313 (comment) - ignoring this, because it didn't account for the weekend.

@fedirjh can you complete the checklist and we can proceed to payment?

[fedirjh]

• Link to the PR: 5bd48f8
• Link to comment: 5bd48f8#r120743096
• Link to discussion: N/A this is a regression from the ongoing Onyx migration.
• Determine if we should create a regression test for this bug. I think we have a regression test.

---

Regression Test Proposal

1. Login with an account that have policy expense beta access
2. Create new workspace
3. Verify the Workspace Chat appears in LHN, Search and Request money
4. Verify the Workspace doesn’t not appear in other places ( New chat, New group, Send money and Split bill)

Do we agree 👍 or 👎

[fedirjh]

@trjExpensify Let's assign @narefyev91 as well since he has reviewed the PR as C+.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[trjExpensify]

Okay great, paid Fedi out so I'm closing this issue. Thanks everyone!