[HOLD for payment 2023-06-05] Thread Attachment is not translated into Spanish In LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Preferences > Language
2. Select Spanish language and go back
3. Now open a Chat
4. Send an Attachment to user
5. Click on "Reply in thread"
6. Check Attachment LHN

Expected Result:

Thread Attachment should be translated into Spanish In LHN

Actual Result:

Thread Attachment is not translated into Spanish In LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684419305175989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fd375ab383f2bad8
• Upwork Job ID: 1661306443832766464
• Last Price Increase: 2023-05-24

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fd375ab383f2bad8

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[Gonals]

I'll do a quick fix for this

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Display attachment text in Spanish in threads #19517

If no regressions arise, payment will be issued on 2023-06-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[maddylewis]

Payments

• Pay Reporting bonus to ayazhussain79 ($250)
• Pay C+ payment to @parasharrajat ($1000)

[ayazhussain79]

@maddylewis offer accepted

[maddylewis]

@parasharrajat - whenever you have a chance, will you review this checklist to confirm if we need to do any of those steps? thanks!

#19467 (comment)

[parasharrajat]

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: #18522
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18522/files#r1220854240

[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: There is no need for any discussion on this issue. It is a simple translation-related change.

[@parasharrajat] Determine if we should create a regression test for this bug. Yes

[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #19467 (comment)

[parasharrajat]

Regression Test Steps

1. Open a Chat on the App.
2. Send an Attachment to the user.
3. Click on "Reply in thread" on the attachment.
4. Check the Attachment related thread chat in LHN.
5. Go to Settings > Preferences > Language.
6. Select the Spanish language and go back.
7. Check the Attachment thread in LHN and the report title for the thread.

Do you agree 👍 or 👎 ?

[maddylewis]

Added regression test proposal to for Applause to add to Test Rail. Just waiting for @parasharrajat to accept the offer so i can process payment :)

[maddylewis]

paid!