[HOLD for C+ payment via newdot] [HOLD Same root cause as #16923] [$2000] Hover background is stuck if we remove all reaction from message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. On older message (preferably message before 2-3 latest messages), react with emote
4. Click on reacted emoji below message to remove it and observe that background color is stuck for that message

Expected Result:

App should remove hover background color from message if we hover out of that message

Actual Result:

Hover background color is stuck when we remove all reacted emojis from message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.11.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

hover.stuck.on.reaction.removal.mp4

Recording.517.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683367237994489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019548eceb851e8301
• Upwork Job ID: 1656396922593226752
• Last Price Increase: 2023-05-31

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@garrettmknight Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019548eceb851e8301

[melvin-bot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[garrettmknight]

Reproduced. Opening up and reassigning since I'm going OOO.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[allroundexperts]

My proposal here would fix this as well.

[marcaaron]

Looks like we are still waiting for proposals. @allroundexperts if you proposal would fix this then feel free to add it here so @thesahindia can review it.

[allroundexperts]

Looks like we are still waiting for proposals. @allroundexperts if you proposal would fix this then feel free to add it here so @thesahindia can review it.

I think it makes more sense to keep this on hold until #16923 is resolved?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Resolve stuck hover due to the mouse leave event not triggered. #26690

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @dhanashree-sawant requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

@kadiealexander This is completed.

[kadiealexander]

@parasharrajat are any payouts due here do you think? Doesn't seem like it

[dhanashree-sawant]

Is it eligible for reporting bonus? In PR, 3 issues where marked in Fixed issue so not sure if this issue was helpful in the solution

[kadiealexander]

@dhanashree-sawant we generally pay the reporting bonus to the person who first reported the bug that led to the fix, which would have been this issue.

[dhanashree-sawant]

Got it, thanks

[kadiealexander]

@parasharrajat any update?

[parasharrajat]

Sorry, missed this comment @kadiealexander Yes, I think it is eligible for partial C+ payment (25%). If you can leave the payment summary here, I can request it.

[kadiealexander]

Payouts due:

• Contributor+: $500 @parasharrajat
• Reporter: $250 @dhanashree-sawant

Eligible for 50% #urgency bonus? No

Upwork job is here

[dhanashree-sawant]

Hi @kadiealexander, can you once check @parasharrajat comments on #16923 before closing this?

[kadiealexander]

I'll wait to see what @dylanexpensify agrees to.

[dylanexpensify]

Yes, let's get that payment from the mentioned issue above paid out as well for @dhanashree-sawant @kadiealexander! 🙇‍♂️

[kadiealexander]

Thanks Dylan! Updated the payment summary and sent an Upwork offer to you @dhanashree-sawant :)

[dhanashree-sawant]

Thanks @kadiealexander, I have accepted the offer.

[parasharrajat]

Payment requested as per #18555 (comment).

[JmillsExpensify]

$500 payment approved for @parasharrajat based on BZ summary.

[parasharrajat]

@kadiealexander We are good to close this.