[HOLD for payment 2023-05-16] [$1000] Long pressing and dragging mouse moves the window.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the desktop app.
2. Right click on a message that is close to the Report header.
3. Long press on the quick emoji reactions.
4. Drag the mouse.

Expected result:

The window should not move along with mouse on the ContextMenu.

Actual result:

The window moves while dragging the contextMenu.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-01.at.3.42.16.PM.mov

Recording.176.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682935961676639

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b1bae4e7beab1fa9
• Upwork Job ID: 1653112883352539136
• Last Price Increase: 2023-05-01

[MelvinBot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

90% sure this can be external, @AndrewGable any reason it wouldn't be? I was able to reproduce.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01b1bae4e7beab1fa9

[AndrewGable]

Nope - External!

[MelvinBot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[MelvinBot]

Current assignee @AndrewGable is eligible for the External assigner, not assigning anyone new.

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that when the Context Menu is open and overlaps with the Header, if we were to click and drag the window in the emoji row, the whole window moves on Desktop.

What is the root cause of that problem?

The root cause behind the issue is that to support the window being dragged on the HeaderView, we use the -webkit-app-region: drag; CSS property defined in a selector in index.html. Using this ID in the nativeID, we allow the whole HeaderView to be draggable.

App/src/pages/home/HeaderView.js

Line 88 in 435f3ef

<View style={[styles.appContentHeader]} nativeID="drag-area">

App/web/index.html

Lines 37 to 39 in 66b0a4d

	#drag-area {
	-webkit-app-region: drag;
	}

When the context menu is open and overlaps with the HeaderView, which is generally just the emoji row, this property is still valid on the whole header region, causing the window to be draggable when the user clicks and drags on the context menu.

What changes do you think we should make in order to solve the problem?

We need to add a new selector to index.html, which can be #no-drag-area and adds the property -webkit-app-region: no-drag;. We will then add the ID as nativeID to the context menu in this View:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Lines 66 to 69 in ce3b938

	<View
	ref={this.props.contentRef}
	style={this.wrapperStyle}
	>

This will ensure that the area in context menu overlapping with the header is not draggable.

What alternative solutions did you explore? (Optional)

None

Result

2023-05-02.01-05-20.mp4

[fedirjh]

Thanks for sharing your proposal, @Prince-Mendiratta. Your proposal looks good.

However, I have a different perspective on the placement of the context menu. I think that the context menu should not overlap with the HeaderView. I believe that shifting it below the HeaderView would be even better, as this would fix the issue and make the HeaderView always visible and accessible to users. What do you think about this approach ?

cc @shawnborton @AndrewGable what are your thoughts ?

[parasharrajat]

I don't think we have to change the placement of the context menu. It doesn't give us any advantages. The header will still be blocked from the backdrop of the context menu. The user is well aware of the chat so keeping the header visible doesn't have any advantages.

[shawnborton]

Yeah, I think it's fine if it covers the header personally.

[fedirjh]

Thanks for the input, everyone. Given what was said, I think we can proceed with @Prince-Mendiratta's solution.

🎀👀🎀 C+ reviewed

cc @AndrewGable

[MelvinBot]

📣 @Prince-Mendiratta You have been assigned to this job by @AndrewGable!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Prince-Mendiratta]

Thank you everyone!

PR is up for review!

cc @fedirjh @AndrewGable

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [ContextMenu] Do not drag window on click and drag action on the context menu #18365

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: Added to Items to check occasionally

[Prince-Mendiratta]

Sharing the timeline of this issue to help with the eventual analysis, calculated with this tool.

🐛 Issue created at: Mon, 01 May 2023 16:37:19 GMT
🧯 Help Wanted at: Mon, 01 May 2023 19:03:35 GMT
🕵🏻 Contributor assigned at: Wed, 03 May 2023 19:42:05 GMT
🛸 PR created at: Wed, 03 May 2023 19:58:33 GMT
🎯 PR merged at: Fri, 05 May 2023 17:36:14 GMT
⌛ Business Days Elapsed between assignment and PR merge: 1

[melvin-bot]

@AndrewGable, @mallenexpensify, @fedirjh, @Prince-Mendiratta Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@parasharrajat @fedirjh @Prince-Mendiratta can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b1bae4e7beab1fa9

@fedirjh can you please comment on the top THREE items above?
For Determine if we should create a regression test for this bug. I think this is a bug we don't want to test on every single run, added it to Items to check occasionally in the testing guidelines here

Eligible for timeliness bonus based on @Prince-Mendiratta post above

[fedirjh]

@mallenexpensify Thanks ! Accepted . I will finish the BugZero Checklist shortly.

[fedirjh]

• Link to the PR: desktop title bar customization #1533
• Link to comment: This conversation has been locked
• Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1684536443114849

[mallenexpensify]

@parasharrajat @fedirjh @Prince-Mendiratta paid!!
Thanks y'all