Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BasePreRenderer #17007

Closed
roryabraham opened this issue Apr 6, 2023 · 24 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate the BasePreRenderer component to use PressableWithoutFeedback.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0104c22d635f6c3e27
  • Upwork Job ID: 1668443401468108800
  • Last Price Increase: 2023-06-13
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 1][Accessible Pressable] Migrate BasePreRenderer [Group 1][Accessible Pressable] Migrate BasePreRenderer May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

Hello, can you assign it to me too?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 18, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels May 31, 2023
@melvin-bot melvin-bot bot changed the title [Group 1][Accessible Pressable] Migrate BasePreRenderer [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BasePreRenderer May 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 6, 2023
@aimane-chnaif
Copy link
Contributor

Can we handle payment and close the issue?
cc: @garrettmknight since you were assigned already

@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

📣 @aimane-chnaif You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@roryabraham
Copy link
Contributor Author

@garrettmknight, the only payment due here is $1000 to @aimane-chnaif, and it's ready to pay out immediately

@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 16, 2023

@garrettmknight, @roryabraham, @robertKozik, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@roryabraham
Copy link
Contributor Author

Oh, my fault @garrettmknight is on sabbatical until mid-july.

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2023
@roryabraham roryabraham added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Jun 17, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 17, 2023

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 17, 2023

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

@kadiealexander
Copy link
Contributor

Offer sent here @aimane-chnaif, please accept!

@kadiealexander
Copy link
Contributor

Sorry, I'm also going OOO as of tomorrow so reassigning again to do the needful.

@kadiealexander kadiealexander removed the External Added to denote the issue can be worked on by a contributor label Jun 19, 2023
@kadiealexander kadiealexander removed their assignment Jun 19, 2023
@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Triggered auto assignment to @muttmuure (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

@kadiealexander kadiealexander removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 19, 2023
@kadiealexander
Copy link
Contributor

kadiealexander commented Jun 19, 2023

@muttmuure thanks for covering this while I'm OOO! The only payment waiting here is $1000 for @aimane-chnaif as soon as he accepts the contract, then this can be closed (context).

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Jun 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2023
@muttmuure
Copy link
Contributor

All paid up

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

10 participants