[HOLD for payment 2023-08-02] [$250] Migrate ReportSettingsPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/ReportSettingsPage.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01248a2f79831e8cf8
• Upwork Job ID: 1678837689196437504
• Last Price Increase: 2023-07-11

[dummy-1111]

I'd love to work on this.

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[payal-lathidadiya]

I'm interested to work on this

[alpeshl]

Can I work on this?

[olexyt]

I can work on this issue.

[rayane-d]

Can I work on this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01248a2f79831e8cf8

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @alexxxwork 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[deetergp]

@NicMendonca @fedirjh I am going to be going OOO till Monday July 24th. If you need engineering import before then, feel free to remove me and re-apply the label to reassign it.

[ghost]

If it is available I am open to work on it

[alexxxwork]

The PR is ready

[melvin-bot]

@deetergp, @alexxxwork, @NicMendonca, @fedirjh Eep! 4 days overdue now. Issues have feelings too...

[alexxxwork]

@MelvinBot the PR is merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Component refactor: migrate ReportSettingsPage to function component #22927

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @alexxxwork requires payment
• @fedirjh requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[NicMendonca]

• reporter: NONE
• Contributor: @alexxxwork - $250
• C+: @fedirjh - $250

[fedirjh]

@NicMendonca Payment is $250 for both Contributor & C+

[NicMendonca]

@fedirjh why? 😅 Where did we agree that?

[NicMendonca]

okay - updated this to $250: #16250 (comment)

[NicMendonca]

@alexxxwork @fedirjh you both have been paid via Upwork

[alexxxwork]

@NicMendonca I was assigned to this issue on jul 15 and the PR was ready the same day. It was reviewed and approved by C+ on jul 18 (that is 2 business days since assignment) and we were waiting for @deetergp to approve changes but they were OOO for that week (from 17 to 23 jul). While this PR hadn't been merged there were two other PRs changing this component so I've updated the code twice to include changes. Could this issue be eligible for speed bonus taking in account the details above?

[NicMendonca]

@alexxxwork thanks for following up! We've agreed internally that it's 250$ flat payment for all functional components migration and they are not eligbile for speed bonus.

[alexxxwork]

@NicMendonca Thanks for clarification!