[HOLD for payment 2023-07-24] [$250] Migrate KeyboardShortcutsModal.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/KeyboardShortcutsModal.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount,componentWillUnmount, componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01678291804db5d8d5
• Upwork Job ID: 1678837080014872576
• Last Price Increase: 2023-07-11

[muxriddinmuqimov77]

I'd like to work on this issue

[dummy-1111]

I'd love to work on this.

[disha-np]

Can I work on this migration issue

[olexyt]

I can work on this issue.

[rayane-d]

Can I work on this issue?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01678291804db5d8d5

[melvin-bot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[rayane-d]

Can I work on this issue?

[alexxxwork]

I would love to work on this issue

[payal-lathidadiya]

dibs?

[alpeshl]

Can I work on this?

[crazy-coding]

I'd love to work on this.

[disha-np]

I'd like to work on this

[yh-0218]

I can work on this task. Thanks.

[kmwamasali]

would like to work on this

[Talha345]

I'd love to work on this.

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rayane-d]

PR Merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.41-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate KeyboardShortcutsModal.js to function component #22743

If no regressions arise, payment will be issued on 2023-07-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[iwiznia]

Seems this is mostly ready, so not unassigning myself, but if this does not get closed, @dylanexpensify please unassign and re-assign another engineer since I am going on sabbatical

[rayane-d]

Payment requested

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[rayane-d]

Waiting for payment

[rayane-d]

Bumps @dylanexpensify @arosiclair

[dylanexpensify]

Sorry! Doing now!

[dylanexpensify]

Paid! TY!

[arosiclair]

I think this is all set so closing