[HOLD for payment 2023-07-05] [$1000] FEATURE REQUEST: Increase the size of composer a bit bigger and easier to tap

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem:

The size of the composer is smaller than standard button size

Solution:

Increase the size of our composer just slightly so that the send button becomes 40px tall, which is a standard button size and is a bit bigger and easier to tap

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678380227758669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0114ab49b58fd19b29
• Upwork Job ID: 1669463781749805056
• Last Price Increase: 2023-06-15

[MelvinBot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[daraksha-dk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Increase the size of composer a bit bigger and easier to tap

What is the root cause of that problem?

This is a simple feature request.

What changes do you think we should make in order to solve the problem?

We can do this by not using componentSizeNormal value here and instead of that we would need to define and use another variable for 48px.
After that we will be making the necessary changes to styles.js for places like chatItemSubmitButton, chatItemEmojiButton etc

Additionally, we can also increase the width/height of emoji button as well if required.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@kavimuru, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[shawnborton]

I feel like we still want to do this. Do you agree @JmillsExpensify @trjExpensify ? I think I'll slap External on it so we can get this through the process.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0114ab49b58fd19b29

[melvin-bot]

Triggered auto assignment to @zanyrenney (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[syedsaroshfarrukhdot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Increase the size of composer a bit bigger and easier to tap

What is the root cause of that problem?

No Root Cause Component Was Designed In This Way This Is A New Feature Request

What changes do you think we should make in order to solve the problem?

We need to define another variable such as componentSizeNormal and use it in chatItemComposeBox to set minHeight to 48px

We need to update composerSizeButton to following style by updating its heigh and width and paddings.

      composerSizeButton: {
          alignSelf: 'center',
          height: 40,
          width: 40,
          padding: 10,
          margin: 4,
          borderRadius: variables.componentBorderRadiusRounded,
          backgroundColor: themeColors.transparent,
      },

We also need to update chatItemEmojiButton styles

     chatItemEmojiButton: {
            alignSelf: 'flex-end',
            borderRadius: variables.buttonBorderRadius,
            height: 40,
            marginVertical: 4,
            paddingHorizontal: 10,
            justifyContent: 'center',
        },

Also update chatItemSubmitButton

      chatItemSubmitButton: {
              alignSelf: 'flex-end',
              borderRadius: variables.componentBorderRadiusRounded,
              backgroundColor: themeColors.transparent,
              height: 40,
              padding: 10,
              margin: 4,
              justifyContent: 'center',
          },

What alternative solutions did you explore? (Optional)

[trjExpensify]

Yeah, nice! Much easier to smash that send button!

[sobitneupane]

Thanks for the proposal.

Proposal from @daraksha-dk looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @daraksha-dk got assigned: 2023-06-19 09:14:05 Z
• when the PR got merged: 2023-06-26 14:11:47 UTC
• days elapsed: 5

On to the next one 🚀

[joekaufmanexpensify]

I was assigned this bug . Were we changing the size of the FAB button in this issue to be 32x40?

I see in the tests for the PR here that this is the expected size, but curious if we meant to change that in this issue.

[shawnborton]

I don't think that's a bug, I think it's fine as-is.

[joekaufmanexpensify]

Cool cool, ty!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat req: increase composer's height to 48px #21131

If no regressions arise, payment will be issued on 2023-07-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune / @zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

@sobitneupane and @daraksha-dk I have invited you to the job on upwork. there is no reporting bonus here as this was reported internally.

Please accept the job for payouts.

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

This is a feature request not a bug. So, I don't think BugZero Checklist applies here.

[sobitneupane]

Requested money on Expensify. So, payment will be settled from Expensify.

cc: @zanyrenney

[zanyrenney]

Brilliant thank you @sobitneupane - I'll view your payment as complete then!

[zanyrenney]

@daraksha-dk can you confirm if you'll be doing the same, and requesting money on Expensify instead?

[daraksha-dk]

@zanyrenney I'm not sure how to get paid using expensify. Has there been any announcement regarding this?

[sobitneupane]

@zanyrenney @daraksha-dk It is only being used (internally) by few Contributor+ now. More context: https://expensify.slack.com/archives/C02NK2DQWUX/p1686871517189609

[zanyrenney]

Thanks @sobitneupane - apologies for the confusion @daraksha-dk

[zanyrenney]

hey @daraksha-dk offer sent, please accept.

no bonus due

[zanyrenney]

Paid @daraksha-dk

@sobitneupane will be managing payment through Expensify.

there is no reporting bonus as it was an internal report.

Good to close here!