[HOLD for payment 2023-04-13] [$4000] Switching other app after receiving messages, message will be marked 'read' (I.e. message sender's name not bolded)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the android app
2. Receive messages from user
3. After receiving message switch to the other app then return to the expensify app
4. Check that the name of the user who sent the message are bold.

(In the video watch "jimmy" name was bold when he sent message when i switch to other app it will not remain bold)

Expected Result:

Every one's name should remain bold even if i switch to the other app

Actual Result:

One of the user name not remain bold after switching to other app

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

20230214222649.mp4

mobizen_20230302_131644.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676397495296059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f05dfc9d55964fa
• Upwork Job ID: 1631545626203709440
• Last Price Increase: 2023-03-17

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bfitzexpensify]

Removed the reference to '3/4' users in the title since I was able to reproduce with just a single new message coming in.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~012f05dfc9d55964fa

[MelvinBot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[MelvinBot]

Triggered auto assignment to @Beamanator (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

@bfitzexpensify Should this issue be put on this tracker too?

[nirodg]

Is this bounty still available?

[nirodg]

Contributor details
Your Expensify account email: dorin.brage@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ab511a1a56549614

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[nirodg]

@bfitzexpensify @bernhardoj Is it possible to get access to this link? https://stackoverflow.com/c/expensify/questions/13283/13284#13284 I will need to follow the steps for the Android build, however, it seems like I need expensify.com email account to access it

[bernhardoj]

I believe that's internal only. You can follow the steps here instead.

[mananjadhav]

Thanks for the help here @bernhardoj. @nirodg As @bernhardoj mentioned you can use the steps to create the Android build, but I believe running the dev build with USB debugging on the physical device should be enough here.

[KartikDevelopment]

Your Expensify account email: kartikyadav637@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~014a841945eafdea43

[KartikDevelopment]

Contributor details
Your Expensify account email: kartikyadav637@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~014a841945eafdea43

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.95-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix switching other app after receiving messages, message will be marked 'read' #16467

If no regressions arise, payment will be issued on 2023-04-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav / @Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav / @Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@bfitzexpensify] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:https://github.com/Expensify/Expensify/issues/277366

[mananjadhav]

@Beamanator @bfitzexpensify I think the Test steps in the PR should be enough for the regression test proposal. I think we should add a regression test because Mark as Read often breaks and we don't want to end up looking at this again in case future changes break this again. What do you folks think?

I checked the PR and I couldn't pinpoint to the exact reason as to this stopped working or whether it ever worked before we added Freeze.

Lastly, @bfitzexpensify I think this is ready for payout. Could you help with this please?

[MelvinBot]

@mananjadhav, @Beamanator, @hoangzinh, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Beamanator]

Quick bump @bfitzexpensify 😬 👍

[bfitzexpensify]

Sorry for the delay here 😅. Reposted the job on Upwork and sent out offers.

I agree with adding this as a regression test and using the test steps for that - will get on to that tomorrow!

[mananjadhav]

@bfitzexpensify This PR is not eligible for timeline bonus. Can you resend the offer without the timeline bonus? Payout for the PR amount only.

[mananjadhav]

Thanks @bfitzexpensify for the payout here.

[hoangzinh]

@bfitzexpensify I got 2 offers, when I click in both of offers, it's saying "This offer is not available anymore"

[bfitzexpensify]

@hoangzinh Hm, I'm seeing this:

I reposted the job and tried to invite you again and got the same response.

Can you please apply to it here?

[hoangzinh]

@bfitzexpensify sorry for this inconvenient, my upwork account is on hold. I have to verify my ID first. Can we wait for couple of days please?

[bfitzexpensify]

Yes, no problem! The job will remain open, just let me know here when you apply to it.

[hoangzinh]

Hi @bfitzexpensify I have resolved my upwork account. It's back to normal now. I have applied to the job in Upwork according to suggestion here #15634 (comment). Do you happen to send me another offer again? Thank you so much.

[bfitzexpensify]

@hoangzinh offer sent!

[bfitzexpensify]

Issue to update regression test here - https://github.com/Expensify/Expensify/issues/277366

[hoangzinh]

@bfitzexpensify accepted offer. Thank you

[bfitzexpensify]

Great, all payments now complete.

[MelvinBot]

@mananjadhav, @Beamanator, @hoangzinh, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Beamanator]

@bfitzexpensify looks like payments have been made, yeah? Closing this out for now, feel free to reopen if needed 👍