[HOLD for payment 2023-04-18] [$8000] Manage member - User deleted offline becomes visible again when the Internet is turned off

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App
2. Login with any account
3. Go to Settings -> Workspaces -> Open any workspace -> Manage members
4. Invite a new user if you haven't yet
5. Turn off the internet connection
6. Remove some users (it should become crossed out)
7. Turn on the internet (deleted users disappear)
8. Turn off the internet connection
9. Pay attention to users who have been removed offline

Expected Result:

Deleted users do not become visible

Actual Result:

User deleted offline becomes visible again

Workaround:

Unkown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.69.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5932496_Record_2023-02-10-19-04-42_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb8e9a5669261ed5
• Upwork Job ID: 1631061620690505728
• Last Price Increase: 2023-04-04

[MelvinBot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[miljakljajic]

I was able to reproduce this on mobile, but not on web:

Adding the engineering label to confirm whether this can be worked on externally.

WhatsApp.Video.2023-02-14.at.15.02.52.mp4

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[miljakljajic]

What do you think @chiragsalian am I good to put the external label? Bear in mind that I've only been able to reproduce this on mobile so the scope is probably a bit narrower.

[chiragsalian]

I cannot reproduce the problem on ios or web. Also i think i see the issue. My theory is because the actions are done so fast that the API probably has not finished and the front end hasn't received the updated pusher data yet.

Can you guys retest and this time after going online wait 10s and then go offline?

[chiragsalian]

Not overdue, waiting to hear back from others.

[MelvinBot]

@chiragsalian, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[chiragsalian]

@miljakljajic / @kbecciv were you guys able to retest with the steps i mentioned here? I want to narrow down the source of the problem.

[MelvinBot]

@chiragsalian @miljakljajic this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[chiragsalian]

Friendly bump here @miljakljajic / @kbecciv to retest.

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.98-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/15048: Add successData into DeleteMembersFromWorkspace API #17078

If no regressions arise, payment will be issued on 2023-04-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue @tienifr
• Contributor+ that helped on the issue and/or PR @aimane-chnaif

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif / @grgia] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif / @grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif / @grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@miljakljajic] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

@tienifr what's your upwork profile? Can you apply to the job: https://www.upwork.com/ab/applicants/1631061620690505728/job-details

[tienifr]

@miljakljajic I've applied, thanks!

[miljakljajic]

Reassigning so that someone else can pay promptly on Monday when I'm OOO! Contracts have been sent to both @tienifr and @aimane-chnaif :)

[MelvinBot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[grgia]

Not overdue, PR in regression period. @aimane-chnaif could you look at the BZ checklist for this one?

[aimane-chnaif]

This issue existed from the beginning when we migrate policy API to remove policy members in #10452.
This issue is edge case and I'd say no PRs caused regression. So I think first 3 items can be checked off.

I think it would be good to add something like this to regression test step:
If we add new delete api command, verify that optimisticData, successData, failureData are correctly set to prevent flickering while switching network online/offline.

@grgia do you agree?

[tjferriss]

Payments have been made via Upworks.

[tienifr]

@tjferriss thanks, I think this is also eligible for the PR timeline bonus since it's merged within 3 business days.

[tjferriss]

@tienifr I thought that might have been why you both applied in Upworks for $12k, but when I was reviewing the issue it appears there are four days between the assignment and PR being merged.

Assignment:

PR is merged:

[aimane-chnaif]

There was weekend.
@tjferriss this is useful calculator: https://ex-syt.glitch.me/. You can use it for further issues 🙂

[grgia]

Not overdue, in payment step cc @tjferriss

[tjferriss]

My mistake. That tool is incredibly helpful. I've just sent you both a bonus payments via Upworks.

@grgia do you agree with @aimane-chnaif feedback here: #15048 (comment). If so, I think we can close this out.

[grgia]

@tjferriss yes, I would agree. closing out!