[HOLD for payment] [$250] BUG: Prevent editing messages sent to Chronos

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send any message to chronos
2. Edit message sent to chronos
3. See Auth UpdateReportComment returned an error
4. Notice that the edits were not recognized, either

Expected Result:

User should not be to initiate editing messages sent to Chronos

Actual Result:

User is able to try to edit their message. An error message Auth UpdateReportComment is surfaced and the edit wasn’t recognized. A red dot is also shown besides chronos in the LHN.

Workaround:

Sign out and sign back in to clear the error red dot.

Platform:

Where is this issue occurring?

• All platforms

Version Number: 1.2.12-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.653.mp4

Expensify/Expensify Issue URL:
Issue reported by: @michaelhaxhiu
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665171071433639

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[abekkala]

This came in over the weekend and I'm out sick. reassigning to get some eyes on this.

[michaelhaxhiu]

I'll take it :)

[abekkala]

Oh! thanks @michaelhaxhiu I was just about to apply the label for assignment. thanks for taking!

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

Shall investigate today

[chiragsalian]

Can reproduce this on dev too. Should be pretty straightforward to debug and address.
Demoting to weekly since it mostly affects us internally.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

[melvin-bot]

@tjferriss, @sobitneupane, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

Whoa, super sorry I missed this everyone.

Since we are preventing users to edit message, do we want to prevent deleting message as well?

Yes, prevent delete as well as edit.

[melvin-bot]

📣 @jayeshmangwani You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jayeshmangwani]

PR is up
cc: @sobitneupane @roryabraham

[roryabraham]

PR merged

[roryabraham]

Created a follow-up PR here to clean up some propTypes inconsistencies/mistakes that I saw

[melvin-bot]

@tjferriss, @sobitneupane, @jayeshmangwani, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

Just waiting on deploy, QA, and payment

[roryabraham]

This was deployed to production 5 days ago. cc @tjferriss

[tjferriss]

Ok I'm manually adding the checklist to close this out:

• @jayeshmangwani / @roryabraham The PR that introduced the bug has been identified. Link to the PR: n/a – this was not a regression
• @jayeshmangwani / @roryabraham The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a – this was not a regression
• @jayeshmangwani / @roryabraham A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a – I think that this was just an oversight in a very old design doc.
• @tjferriss A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/248228
• @tjferriss Complete payment to @sobitneupane and @jayeshmangwani after 7 days.

[jayeshmangwani]

this issue should be ready for payment, PR is in production 13 days ago
cc: @tjferriss @roryabraham

[tjferriss]

Thanks for the reminder. It looks like the job post expired. I just set up a new one here - https://www.upwork.com/jobs/~0162b815998a19498c.

@jayeshmangwani and @sobitneupane can you both please apply? Let me know when you do here and I'll process payment promptly.

[jayeshmangwani]

@tjferriss Applied for the job

[sobitneupane]

@tjferriss Applied. This is eligible for 50% bonus as well.

[tjferriss]

Ok payments have been sent.

[tjferriss]

@jayeshmangwani / @roryabraham can you please complete the steps here?

[roryabraham]

done

[tjferriss]

Ok it looks like we've checked off all the tasks so I'm going to close this out.