Merge pull request #22781 from hoangzinh/df/22037

Fix change language also trigger submit Sign in validation form when magic codes are fullfilled
Expensify · Jul 14, 2023 · df2e3eb · df2e3eb
2 parents 0b00e1c + ec2fd2e
commit df2e3eb
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/components/MagicCodeInput.js b/src/components/MagicCodeInput.js
@@ -147,9 +147,11 @@ function MagicCodeInput(props) {
     useEffect(() => {
         validateAndSubmit();
 
-        // We have not added the editIndex as the dependency because we don't want to run this logic after focusing on an input to edit it after the user has completed the code.
+        // We have not added:
+        // + the editIndex as the dependency because we don't want to run this logic after focusing on an input to edit it after the user has completed the code.
+        // + the props.onFulfill as the dependency because props.onFulfill is changed when the preferred locale changed => avoid auto submit form when preferred locale changed.
         // eslint-disable-next-line react-hooks/exhaustive-deps
-    }, [props.value, props.shouldSubmitOnComplete, props.onFulfill]);
+    }, [props.value, props.shouldSubmitOnComplete]);
 
     useEffect(() => {
         if (!props.autoFocus) {