Merge pull request #41552 from gijoe0295/gijoe/38683

hide delete option for multilevel tags
Expensify · May 10, 2024 · c00ca12 · c00ca12
2 parents 7535c89 + 9c12a5a
commit c00ca12
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts
@@ -250,6 +250,13 @@ function getCountOfEnabledTagsOfList(policyTags: PolicyTags) {
     return Object.values(policyTags).filter((policyTag) => policyTag.enabled).length;
 }
 
+/**
+ * Whether the policy has multi-level tags
+ */
+function isMultiLevelTags(policyTagList: OnyxEntry<PolicyTagList>): boolean {
+    return Object.keys(policyTagList ?? {}).length > 1;
+}
+
 function isPendingDeletePolicy(policy: OnyxEntry<Policy>): boolean {
     return policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
 }
@@ -432,6 +439,7 @@ export {
     getTagList,
     getCleanedTagName,
     getCountOfEnabledTagsOfList,
+    isMultiLevelTags,
     isPendingDeletePolicy,
     isPolicyEmployee,
     isPolicyOwner,

diff --git a/src/pages/workspace/tags/TagSettingsPage.tsx b/src/pages/workspace/tags/TagSettingsPage.tsx
@@ -66,8 +66,9 @@ function TagSettingsPage({route, policyTags}: TagSettingsPageProps) {
     };
 
     const isThereAnyAccountingConnection = Object.keys(policy?.connections ?? {}).length !== 0;
+    const isMultiLevelTags = PolicyUtils.isMultiLevelTags(policyTags);
     const threeDotsMenuItems = [];
-    if (!isThereAnyAccountingConnection) {
+    if (!isThereAnyAccountingConnection && !isMultiLevelTags) {
         threeDotsMenuItems.push({
             icon: Trashcan,
             text: translate('workspace.tags.deleteTag'),

diff --git a/src/pages/workspace/tags/WorkspaceTagsPage.tsx b/src/pages/workspace/tags/WorkspaceTagsPage.tsx
@@ -164,9 +164,10 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) {
     const getHeaderButtons = () => {
         const options: Array<DropdownOption<DeepValueOf<typeof CONST.POLICY.TAGS_BULK_ACTION_TYPES>>> = [];
         const isThereAnyAccountingConnection = Object.keys(policy?.connections ?? {}).length !== 0;
+        const isMultiLevelTags = PolicyUtils.isMultiLevelTags(policyTags);
 
         if (selectedTagsArray.length > 0) {
-            if (!isThereAnyAccountingConnection) {
+            if (!isThereAnyAccountingConnection && !isMultiLevelTags) {
                 options.push({
                     icon: Expensicons.Trashcan,
                     text: translate(selectedTagsArray.length === 1 ? 'workspace.tags.deleteTag' : 'workspace.tags.deleteTags'),