Merge pull request #20655 from dostongulmatov/fix/#20262-send-money-p…

…opover-position fix send money - green payment button is visible bug
Expensify · Jun 15, 2023 · 9797fa4 · 9797fa4
2 parents a8c202d + 07bdeb3
commit 9797fa4
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/components/ButtonWithDropdownMenu.js b/src/components/ButtonWithDropdownMenu.js
@@ -54,19 +54,23 @@ function ButtonWithDropdownMenu(props) {
     const [popoverAnchorPosition, setPopoverAnchorPosition] = useState(null);
     const {windowWidth, windowHeight} = useWindowDimensions();
     const caretButton = useRef(null);
+    const selectedItem = props.options[selectedItemIndex];
+
     useEffect(() => {
         if (!caretButton.current) {
             return;
         }
+        if (!isMenuVisible) {
+            return;
+        }
         caretButton.current.measureInWindow((x, y, w, h) => {
             setPopoverAnchorPosition({
                 horizontal: x + w,
                 vertical: y + h,
             });
         });
-    }, [windowWidth, windowHeight]);
+    }, [windowWidth, windowHeight, isMenuVisible]);
 
-    const selectedItem = props.options[selectedItemIndex];
     return (
         <View>
             {props.options.length > 1 ? (
@@ -87,9 +91,7 @@ function ButtonWithDropdownMenu(props) {
                         success
                         isDisabled={props.isDisabled}
                         style={[styles.pl0]}
-                        onPress={() => {
-                            setIsMenuVisible(true);
-                        }}
+                        onPress={() => setIsMenuVisible(true)}
                         shouldRemoveLeftBorderRadius
                     >
                         <Icon