Skip to content

Commit

Permalink
Remove named imports
Browse files Browse the repository at this point in the history
  • Loading branch information
JakubKorytko committed Mar 10, 2025
1 parent 8abb843 commit 92a6498
Show file tree
Hide file tree
Showing 2 changed files with 101 additions and 82 deletions.
40 changes: 24 additions & 16 deletions src/hooks/useSingleExecution/useTransactionPreviewData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import useTransactionViolations from '@hooks/useTransactionViolations';
import {calculateAmount} from '@libs/IOUUtils';
import {getAvatarsForAccountIDs} from '@libs/OptionsListUtils';
import {getThumbnailAndImageURIs} from '@libs/ReceiptUtils';
import * as ReportActionsUtils from '@libs/ReportActionsUtils';
import * as ReportUtils from '@libs/ReportUtils';
import {getOriginalMessage, isMoneyRequestAction} from '@libs/ReportActionsUtils';
import {getTransactionDetails, getWorkspaceIcon, isPolicyExpenseChat, isReportApproved, isSettled} from '@libs/ReportUtils';
import type {TransactionDetails} from '@libs/ReportUtils';
import StringUtils from '@libs/StringUtils';
import {createTransactionPreviewConditionals, createTransactionPreviewText, getIOUData} from '@libs/TransactionPreviewUtils';
Expand All @@ -32,15 +32,15 @@ function useTransactionPreviewData(
const [iouReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${iouReportID}`);
const [walletTerms] = useOnyx(ONYXKEYS.WALLET_TERMS);

const isMoneyRequestAction = ReportActionsUtils.isMoneyRequestAction(action);
const transactionID = isMoneyRequestAction ? ReportActionsUtils.getOriginalMessage(action)?.IOUTransactionID : null;
const isIOUActionType = isMoneyRequestAction(action);
const transactionID = isIOUActionType ? getOriginalMessage(action)?.IOUTransactionID : null;
const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`);

const violations = useTransactionViolations(transaction?.transactionID);

const transactions = useMemo<Partial<TransactionDetails>>(() => ReportUtils.getTransactionDetails(transaction) ?? {}, [transaction]);
const transactions = useMemo<Partial<TransactionDetails>>(() => getTransactionDetails(transaction) ?? {}, [transaction]);
const {amount: requestAmount, comment: requestComment, merchant, tag, category, currency: requestCurrency} = transactions;
const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(chatReport);
const isReportAPolicyExpenseChat = isPolicyExpenseChat(chatReport);

const creationalData = useMemo(
() => ({
Expand All @@ -60,9 +60,9 @@ function useTransactionPreviewData(
createTransactionPreviewConditionals({
...creationalData,
areThereDuplicates,
isPolicyExpenseChat,
isReportAPolicyExpenseChat,
}),
[areThereDuplicates, creationalData, isPolicyExpenseChat],
[areThereDuplicates, creationalData, isReportAPolicyExpenseChat],
);

const {shouldShowRBR, shouldShowMerchant, shouldShowSplitShare} = conditionalProps;
Expand All @@ -79,12 +79,11 @@ function useTransactionPreviewData(
const managerID = iouReport?.managerID ?? CONST.DEFAULT_NUMBER_ID;
const ownerAccountID = iouReport?.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID;

const participantAccountIDs =
ReportActionsUtils.isMoneyRequestAction(action) && isBillSplit ? ReportActionsUtils.getOriginalMessage(action)?.participantAccountIDs ?? [] : [managerID, ownerAccountID];
const participantAccountIDs = isMoneyRequestAction(action) && isBillSplit ? getOriginalMessage(action)?.participantAccountIDs ?? [] : [managerID, ownerAccountID];
const participantAvatars = getAvatarsForAccountIDs(participantAccountIDs, personalDetails ?? {});
const sortedParticipantAvatars = lodashSortBy(participantAvatars, (avatar) => avatar.id);
if (isPolicyExpenseChat && isBillSplit) {
sortedParticipantAvatars.push(ReportUtils.getWorkspaceIcon(chatReport));
if (isReportAPolicyExpenseChat && isBillSplit) {
sortedParticipantAvatars.push(getWorkspaceIcon(chatReport));
}

const sessionAccountID = session?.accountID;
Expand All @@ -96,9 +95,18 @@ function useTransactionPreviewData(
() =>
shouldShowSplitShare
? transaction?.comment?.splits?.find((split) => split.accountID === sessionAccountID)?.amount ??
calculateAmount(isPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount ?? 0, requestCurrency ?? '', action.actorAccountID === sessionAccountID)
calculateAmount(isReportAPolicyExpenseChat ? 1 : participantAccountIDs.length - 1, requestAmount ?? 0, requestCurrency ?? '', action.actorAccountID === sessionAccountID)
: 0,
[shouldShowSplitShare, isPolicyExpenseChat, action.actorAccountID, participantAccountIDs.length, transaction?.comment?.splits, requestAmount, requestCurrency, sessionAccountID],
[
shouldShowSplitShare,
isReportAPolicyExpenseChat,
action.actorAccountID,
participantAccountIDs.length,
transaction?.comment?.splits,
requestAmount,
requestCurrency,
sessionAccountID,
],
);

const description = truncate(StringUtils.lineBreaksToSpaces(requestComment), {length: CONST.REQUEST_PREVIEW.MAX_LENGTH});
Expand All @@ -108,8 +116,8 @@ function useTransactionPreviewData(
const {from, to, isIOU} = getIOUData(managerID, ownerAccountID, reportID, personalDetails, (transaction && transaction.amount) ?? 0);

return {
isApproved: ReportUtils.isReportApproved({report: iouReport}),
isSettled: ReportUtils.isSettled(iouReport?.reportID),
isApproved: isReportApproved({report: iouReport}),
isSettled: isSettled(iouReport?.reportID),
isSettlementOrApprovalPartial: !!iouReport?.pendingFields?.partial,
isScanning: hasReceipt && isReceiptBeingScanned(transaction),
displayAmount: isDeleted ? displayDeleteAmountText : displayAmountText,
Expand Down
Loading

0 comments on commit 92a6498

Please sign in to comment.