Skip to content

Commit

Permalink
use correct params for nsqs connection
Browse files Browse the repository at this point in the history
  • Loading branch information
s77rt committed Jan 21, 2025
1 parent 70094b4 commit 7efbf46
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion src/CONST.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5017,7 +5017,6 @@ const CONST = {
quickbooksOnline: 'QuickBooks Online',
xero: 'Xero',
netsuite: 'NetSuite',
// s77rt: Do I need to add NSQS here?
intacct: 'Sage Intacct',
quickbooksDesktop: 'QuickBooks Desktop',
},
Expand Down
2 changes: 1 addition & 1 deletion src/libs/API/parameters/ConnectPolicyToNSQSParams.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
type ConnectPolicyToNSQSParams = {
policyID: string;
// s77rt: ask for the connect params
netSuiteAccountID: string;
};

export default ConnectPolicyToNSQSParams;
3 changes: 2 additions & 1 deletion src/libs/actions/connections/NSQS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import {Connections} from '@src/types/onyx/Policy';

function connectPolicyToNSQS(policyID: string) {
function connectPolicyToNSQS(policyID: string, nsqsAccountID: string) {
const optimisticData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.MERGE,
Expand All @@ -23,6 +23,7 @@ function connectPolicyToNSQS(policyID: string) {

const params: ConnectPolicyToNSQSParams = {
policyID,
netSuiteAccountID: nsqsAccountID,
};

API.write(WRITE_COMMANDS.CONNECT_POLICY_TO_NSQS, params, {optimisticData});
Expand Down
3 changes: 1 addition & 2 deletions src/pages/workspace/accounting/nsqs/NSQSSetupPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ function NSQSSetupPage({policy}: WithPolicyConnectionsProps) {

const connectPolicy = useCallback(
(formValues: FormOnyxValues<typeof ONYXKEYS.FORMS.NSQS_OAUTH2_FORM>) => {
// s77rt use formValues
connectPolicyToNSQS(policyID);
connectPolicyToNSQS(policyID, formValues[INPUT_IDS.NSQS_ACCOUNT_ID]);
Navigation.dismissModal();
},
[policyID],
Expand Down

0 comments on commit 7efbf46

Please sign in to comment.