Skip to content

Commit

Permalink
close context menu when open emoji picker or selected emoji
Browse files Browse the repository at this point in the history
  • Loading branch information
hannojg committed Feb 16, 2023
1 parent 71220c0 commit 44909ab
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 10 deletions.
5 changes: 5 additions & 0 deletions src/components/Reactions/AddReactionBubble.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,23 @@ import emojis from '../../../assets/emojis';
const propTypes = {
sizeScale: PropTypes.number,
iconSizeScale: PropTypes.number,
onPressOpenPicker: PropTypes.func,
onSelectEmoji: PropTypes.func.isRequired,
};

const defaultProps = {
sizeScale: 1,
iconSizeScale: 1,
onPressOpenPicker: () => {

},
};

const AddReactionBubble = (props) => {
const ref = React.createRef();

const onPress = () => {
props.onPressOpenPicker();
EmojiPickerAction.showEmojiPicker(() => {}, (emojiCode) => {
const emoji = _.find(emojis, e => e.code === emojiCode);
if (emoji != null) {
Expand Down
5 changes: 4 additions & 1 deletion src/components/Reactions/QuickEmojiReactions.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,14 @@ const QUICK_REACTIONS = [
const EMOJI_BUBBLE_SCALE = 1.5;

const propTypes = {
onEmojiSelected: PropTypes.func.isRequired,
emojiIconRef: PropTypes.func,
onEmojiSelected: PropTypes.func.isRequired,
onPressOpenPicker: PropTypes.func,
};

const defaultProps = {
emojiIconRef: () => {},
onPressOpenPicker: () => {},
};

const QuickEmojiReactions = props => (
Expand All @@ -59,6 +61,7 @@ const QuickEmojiReactions = props => (
iconSizeScale={1.2}
sizeScale={EMOJI_BUBBLE_SCALE}
onSelectEmoji={props.onEmojiSelected}
onPressOpenPicker={props.onPressOpenPicker}
/>
</View>
);
Expand Down
29 changes: 20 additions & 9 deletions src/pages/home/report/ContextMenu/ContextMenuActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,26 @@ const CONTEXT_MENU_TYPES = {
export default [
{
shouldShow: () => true,
renderContent: (closePopup, {reportID, reportAction}) => (
<QuickEmojiReactions
key="QuickEmojiReactions"
onEmojiSelected={(emoji) => {
// TODO: we need to add the preferred skin tone here as well somehow
Report.toggleReaction(reportID, reportAction, emoji);
}}
/>
),
renderContent: (closePopover, {reportID, reportAction}) => {
const close = () => {
if (!closePopover) {
return;
}
hideContextMenu(false);
};

return (
<QuickEmojiReactions
key="QuickEmojiReactions"
onEmojiSelected={(emoji) => {
// TODO: we need to add the preferred skin tone here as well somehow
Report.toggleReaction(reportID, reportAction, emoji);
close();
}}
onPressOpenPicker={close}
/>
);
},
},
{
textTranslateKey: 'common.download',
Expand Down

0 comments on commit 44909ab

Please sign in to comment.