remove scrollview

Expensify · Mar 9, 2025 · 1c23cb8 · 1c23cb8
1 parent 0005bab
commit 1c23cb8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/src/components/EmptyStateComponent/index.tsx b/src/components/EmptyStateComponent/index.tsx
@@ -4,7 +4,6 @@ import {View} from 'react-native';
 import Button from '@components/Button';
 import ImageSVG from '@components/ImageSVG';
 import Lottie from '@components/Lottie';
-import ScrollView from '@components/ScrollView';
 import Text from '@components/Text';
 import VideoPlayer from '@components/VideoPlayer';
 import useResponsiveLayout from '@hooks/useResponsiveLayout';
@@ -27,9 +26,7 @@ function EmptyStateComponent({
     headerStyles,
     headerContentStyles,
     lottieWebViewStyles,
-    showsVerticalScrollIndicator,
     minModalHeight = 400,
-    shouldEnableScroll = true,
 }: EmptyStateComponentProps) {
     const styles = useThemeStyles();
     const [videoAspectRatio, setVideoAspectRatio] = useState(VIDEO_ASPECT_RATIO);
@@ -85,13 +82,8 @@ function EmptyStateComponent({
     }, [headerMedia, headerMediaType, headerContentStyles, videoAspectRatio, styles.emptyStateVideo, lottieWebViewStyles]);
 
     return (
-        <ScrollView
-            showsVerticalScrollIndicator={showsVerticalScrollIndicator}
-            scrollEnabled={shouldEnableScroll}
-            contentContainerStyle={[{minHeight: minModalHeight}, styles.flexGrow1, styles.flexShrink0, containerStyles]}
-            style={styles.flex1}
-        >
-            <View style={[styles.skeletonBackground, styles.overflowHidden]}>
+        <View style={[{minHeight: minModalHeight}, styles.flexGrow1, styles.flexShrink0, containerStyles]}>
+            <View style={styles.skeletonBackground}>
                 <SkeletonComponent
                     gradientOpacityEnabled
                     shouldAnimate={false}
@@ -125,7 +117,7 @@ function EmptyStateComponent({
                     </View>
                 </View>
             </View>
-        </ScrollView>
+        </View>
     );
 }
 

diff --git a/src/components/EmptyStateComponent/types.ts b/src/components/EmptyStateComponent/types.ts
@@ -25,7 +25,6 @@ type SharedProps<T> = {
     lottieWebViewStyles?: React.CSSProperties | undefined;
     minModalHeight?: number;
     showsVerticalScrollIndicator?: boolean;
-    shouldEnableScroll?: boolean;
 };
 
 type MediaType<HeaderMedia, T extends MediaTypes> = SharedProps<T> & {

diff --git a/src/pages/workspace/expensifyCard/EmptyCardView.tsx b/src/pages/workspace/expensifyCard/EmptyCardView.tsx
@@ -48,7 +48,6 @@ function EmptyCardView({isBankAccountVerified}: EmptyCardViewProps) {
                     subtitle={translate(`workspace.expensifyCard.${isBankAccountVerified ? 'getStartedIssuing' : 'verifyingTheDetails'}`)}
                     headerContentStyles={isBankAccountVerified ? null : styles.pendingStateCardIllustration}
                     minModalHeight={isBankAccountVerified ? 500 : 400}
-                    shouldEnableScroll={false}
                 />
             </View>
             <Text style={[styles.textMicroSupporting, styles.m5]}>{translate('workspace.expensifyCard.disclaimer')}</Text>