fix upload delta build

Expensify · Feb 16, 2024 · 0ceb667 · 0ceb667
1 parent 866de49
commit 0ceb667
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/actions/composite/buildAndroidE2EAPK/action.yml b/.github/actions/composite/buildAndroidE2EAPK/action.yml
@@ -5,10 +5,11 @@ inputs:
   ARTIFACT_NAME:
     description: The name of the workflow artifact where the APK should be uploaded
     required: true
-  UPLOAD_ARTIFACT:
-    description: Whether to upload the APK as an artifact
+  ARTIFACT_RETENTION_DAYS:
+    description: The number of days to retain the artifact
     required: false
-    default: "true"
+    # Thats github default:
+    default: "90"
   PACKAGE_SCRIPT_NAME:
     description: The name of the npm script to run to build the APK
     required: true
@@ -74,7 +75,7 @@ runs:
 
     - name: Upload APK
       uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3
-      if: ${{ inputs.UPLOAD_ARTIFACT == 'true' }}
       with:
         name: ${{ inputs.ARTIFACT_NAME }}
         path: ${{ inputs.APP_OUTPUT_PATH }}
+        retention-days: ${{ inputs.ARTIFACT_RETENTION_DAYS }}
diff --git a/.github/workflows/e2ePerformanceTests.yml b/.github/workflows/e2ePerformanceTests.yml
@@ -126,7 +126,7 @@ jobs:
       - uses: ./.github/actions/composite/buildAndroidE2EAPK
         with:
           ARTIFACT_NAME: delta-apk-${{ steps.getDeltaRef.outputs.DELTA_REF }}
-          UPLOAD_ARTIFACT: false
+          ARTIFACT_RETENTION_DAYS: 3 # We don't need to store the delta apk for long, its only really needed for the next job in this workflow
           PACKAGE_SCRIPT_NAME: android-build-e2edelta
           APP_OUTPUT_PATH: android/app/build/outputs/apk/e2edelta/release/app-e2edelta-release.apk
           MAPBOX_SDK_DOWNLOAD_TOKEN: ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}