Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(initiate-deployment): add auto_merge parameter #106

Conversation

pongraczl
Copy link
Contributor

@pongraczl pongraczl commented Jan 28, 2022

📝 Description

Set auto_merge parameter in initiate-deployment helper always to false.

  • Parameter description from Github docs: "Attempts to automatically merge the default branch into the requested ref, if it's behind the default branch." (the original, default value was auto_merge: true)
  • The default value is true (this is what initiate-deployment is currently using).
  • Adding this parameter gives more control over the behavior of this helper.

🔗 Related Issues

When a PR is not up-to-date with master, auto_merge=true makes the helper failing, but being up-to-date with master is not a requirement in all cases.

@pongraczl pongraczl requested a review from a team as a code owner January 28, 2022 17:19
@danadajian
Copy link
Contributor

danadajian commented Jan 28, 2022

@pongraczl Thanks for finding this! Instead of adding an additional input, could we instead always set auto_merge: false for the helper? I don't envision any case where we would actually want auto_merge: true.

@pongraczl
Copy link
Contributor Author

@danadajian Thanks! Then I simplified those changes to fixed value with auto_merge: false.
(Previously I was not sure if the original true value should remain available to some users.)

@danadajian danadajian changed the title feat(initiate-deployment): add auto_merge parameter fix(initiate-deployment): add auto_merge parameter Jan 31, 2022
@danadajian danadajian merged commit ca2240b into ExpediaGroup:main Jan 31, 2022
@eg-oss-ci
Copy link

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants