-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Don't show trackers for uninstalled apps #305
enhancement: Don't show trackers for uninstalled apps #305
Conversation
@Jean-BaptisteC don't bother about variables looping etc. i will modify those after review. i want to figure out first, what will be the exact changes. |
Why not reuse validPackages variable initialised each time refresh in launchFetch function in fetchUninstalledApps to get app list to reduce calls ? |
I have compared the validPackages and then I will be able to say that the app has been deleted. |
@Jean-BaptisteC does exodusapp.packagename and application.packagename are both the same? |
Yes |
then should i fetch all exodusapps from db and the compare the packagename with the apps those are fetched from |
Yes and why not create a new DAO to get only packagename ? |
Please check the recent commit. |
app/src/main/java/org/eu/exodus_privacy/exodusprivacy/ExodusUpdateService.kt
Outdated
Show resolved
Hide resolved
Works on emulator, apps uninstalled or disabled are remove from database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Pixel 6 - Android 13
✅ Instrumentation tests
Thanks for your work :)
Currently apps are not being removed from the list after they have been uninstalled.
Closes: #302
@Jean-BaptisteC