Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Don't show trackers for uninstalled apps #305

Merged
merged 1 commit into from
Jun 8, 2023
Merged

enhancement: Don't show trackers for uninstalled apps #305

merged 1 commit into from
Jun 8, 2023

Conversation

SamantaTarun
Copy link
Contributor

Currently apps are not being removed from the list after they have been uninstalled.
Closes: #302
@Jean-BaptisteC

@SamantaTarun
Copy link
Contributor Author

SamantaTarun commented Jun 7, 2023

@Jean-BaptisteC don't bother about variables looping etc. i will modify those after review. i want to figure out first, what will be the exact changes.

@Jean-BaptisteC
Copy link
Contributor

Jean-BaptisteC commented Jun 7, 2023

Why not reuse validPackages variable initialised each time refresh in launchFetch function in fetchUninstalledApps to get app list to reduce calls ?
And please remove unused semicolons

@SamantaTarun
Copy link
Contributor Author

Why not reuse validPackages variable initialised each time refresh in launchFetch function in fetchUninstalledApps to get app list to reduce calls ? And please remove unused semicolons

I have compared the validPackages and then I will be able to say that the app has been deleted.

@SamantaTarun
Copy link
Contributor Author

@Jean-BaptisteC does exodusapp.packagename and application.packagename are both the same?

@Jean-BaptisteC
Copy link
Contributor

Yes
Your condition cannot be work because each time validPackages and validPackagesafterUnistalled have same size because you call same function

@SamantaTarun
Copy link
Contributor Author

Yes Your condition cannot be work because each time validPackages and validPackagesafterUnistalled have same size because you call same function

then should i fetch all exodusapps from db and the compare the packagename with the apps those are fetched from
applicationListAfterUninstalled=exodusPackageRepository.getApplicationList(validPackages)

@Jean-BaptisteC
Copy link
Contributor

Yes and why not create a new DAO to get only packagename ?

@SamantaTarun
Copy link
Contributor Author

Yes and why not create a new DAO to get only packagename ?

Please check the recent commit.

@Jean-BaptisteC
Copy link
Contributor

Works on emulator, apps uninstalled or disabled are remove from database
Please fix errors in linter

Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Pixel 6 - Android 13
✅ Instrumentation tests

Thanks for your work :)

@Jean-BaptisteC Jean-BaptisteC merged commit f7817b4 into Exodus-Privacy:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show trackers for uninstalled apps
2 participants