Issue 260 #270
Merged
Issue 260 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Permissions is not order by alphabetically |
|
Wrong regex on short permission:
|
I guess the ANR was actually caused by computing the name on view time. My bad. Edit: Also the sorting is fixed now. |
This is fixed now - turns out the regex can not be fully avoided. But the complicated regex will now only be used in special cases. |
Jean-BaptisteC
approved these changes
May 3, 2023
We do not call the PackageManager from inside a nested for loop anymore. Instead the generation of the Permission instances list was lifted out. Also the number of times we do callbacks to the packageManager is reduced. This should reduce the occurrence of Issue Exodus-Privacy#260 and Issue Exodus-Privacy#264.
Now uses longName for identification and short name for display.
Rebase is done. |
Jean-BaptisteC
added a commit
that referenced
this pull request
May 16, 2023
* Update Github actions to remove network config (#269) * Issue 260 (#270) * Update Github actions to remove network config (#269) * Add sequence diagram of PackageManagerModule * Move calls to PackageManager outside of nested loop We do not call the PackageManager from inside a nested for loop anymore. Instead the generation of the Permission instances list was lifted out. Also the number of times we do callbacks to the packageManager is reduced. This should reduce the occurrence of Issue #260 and Issue #264. * Calculate short name on view time * Add test for identity * Linting * Rewrite test for more accuracy * Avoid regex * Readd sorting of permissions list * Refactor to repository pattern * Update tests accordingly * Linting * Fix typo * Refactor Permission Data Class Now uses longName for identification and short name for display. * Correct sorting of permissions * Fix name computing --------- Co-authored-by: Jean-Baptiste <87148630+Jean-BaptisteC@users.noreply.github.com> * Update to API 33 * Improve config build * Add new permission and enable locales config * Add themed icon * Fix format * Fix resConfig * Bump dependencies * Add sequence diagram * WIP Implement logic to store notification permission info * WIP Use notification permission info in VM * WIP Implementing the permission request logic * WIP Implement permission request * Implement onRequestPermissionsResult * Use single key for saving perm info * Use single key for saving perm info * Check for permission before showing notification * Refactor request and check to own funcs * Add logging * Add ToDo * Move the DataStoreModule * Add A DataStoreRepo and a Storage Interface * Adapt DataStoreModule * Refactor for new architecture * Remove dataStoreModule from Service * Collect only the first elem * Cache config * Inject networkManager in constructor * Reorder functions * Load config as LiveData * Move init to DialogFragment * Use MainActivityViewModel, implement init DialogFragment VM is currently redundant as it would again use identical functionality when saving app data. Also due to init happening in the Fragment now, we need to access functionality from the MAVM. * Don't use flow in insert * Add logging * Start only when permission was asked * Save appAppSetup state * Make compatible with lower API levels * Refactor to exodus names * Implement tests for DataStoreRepo * Make DSModule Object, implement data class for name * Linting * Remove unused var * Remove redundant view model * Check for network connection on startup * Implement explicit saving of app setup status * Save app setup status when done * Only ask permission on API Level 33 and up * Remove saving app setup status * Catch case where no wifi settings are available * Add refresh snackbar when applist is empty * Add refresh snackbar to TrackersFragment as well * Test for correct insertion of app setup state * Make new datastores for each test * Add swipeRefreshLayout when list is null to allow refresh * Remove Snackbar As the swipeRefreshLayout is visible, a button might not be needed. * Remove redundant method calls * Remove unused function * Linting * Fix broken test * Create notification channel unconditionally According to https://developer.android.com/develop/ui/views/notifications/channels#CreateChannel No operation will be performed, when the channel already exists. * Remove unused import * Remove foreground service specific method * Update onDestroy * Split notification build and setup * Add timeout to notification * Refactor stopService * Linting --------- Co-authored-by: Jean-Baptiste <87148630+Jean-BaptisteC@users.noreply.github.com> Co-authored-by: Jean-Baptiste CHARRON <jeanbaptiste.charron@outlook.fr>
Jean-BaptisteC
added a commit
that referenced
this pull request
May 25, 2023
* Update to API 33 * Improve config build * Add new permission and enable locales config * Add themed icon * Fix format * Fix resConfig * Bump dependencies * Api 33 (#273) * Update Github actions to remove network config (#269) * Issue 260 (#270) * Update Github actions to remove network config (#269) * Add sequence diagram of PackageManagerModule * Move calls to PackageManager outside of nested loop We do not call the PackageManager from inside a nested for loop anymore. Instead the generation of the Permission instances list was lifted out. Also the number of times we do callbacks to the packageManager is reduced. This should reduce the occurrence of Issue #260 and Issue #264. * Calculate short name on view time * Add test for identity * Linting * Rewrite test for more accuracy * Avoid regex * Readd sorting of permissions list * Refactor to repository pattern * Update tests accordingly * Linting * Fix typo * Refactor Permission Data Class Now uses longName for identification and short name for display. * Correct sorting of permissions * Fix name computing --------- Co-authored-by: Jean-Baptiste <87148630+Jean-BaptisteC@users.noreply.github.com> * Update to API 33 * Improve config build * Add new permission and enable locales config * Add themed icon * Fix format * Fix resConfig * Bump dependencies * Add sequence diagram * WIP Implement logic to store notification permission info * WIP Use notification permission info in VM * WIP Implementing the permission request logic * WIP Implement permission request * Implement onRequestPermissionsResult * Use single key for saving perm info * Use single key for saving perm info * Check for permission before showing notification * Refactor request and check to own funcs * Add logging * Add ToDo * Move the DataStoreModule * Add A DataStoreRepo and a Storage Interface * Adapt DataStoreModule * Refactor for new architecture * Remove dataStoreModule from Service * Collect only the first elem * Cache config * Inject networkManager in constructor * Reorder functions * Load config as LiveData * Move init to DialogFragment * Use MainActivityViewModel, implement init DialogFragment VM is currently redundant as it would again use identical functionality when saving app data. Also due to init happening in the Fragment now, we need to access functionality from the MAVM. * Don't use flow in insert * Add logging * Start only when permission was asked * Save appAppSetup state * Make compatible with lower API levels * Refactor to exodus names * Implement tests for DataStoreRepo * Make DSModule Object, implement data class for name * Linting * Remove unused var * Remove redundant view model * Check for network connection on startup * Implement explicit saving of app setup status * Save app setup status when done * Only ask permission on API Level 33 and up * Remove saving app setup status * Catch case where no wifi settings are available * Add refresh snackbar when applist is empty * Add refresh snackbar to TrackersFragment as well * Test for correct insertion of app setup state * Make new datastores for each test * Add swipeRefreshLayout when list is null to allow refresh * Remove Snackbar As the swipeRefreshLayout is visible, a button might not be needed. * Remove redundant method calls * Remove unused function * Linting * Fix broken test * Create notification channel unconditionally According to https://developer.android.com/develop/ui/views/notifications/channels#CreateChannel No operation will be performed, when the channel already exists. * Remove unused import * Remove foreground service specific method * Update onDestroy * Split notification build and setup * Add timeout to notification * Refactor stopService * Linting --------- Co-authored-by: Jean-Baptiste <87148630+Jean-BaptisteC@users.noreply.github.com> Co-authored-by: Jean-Baptiste CHARRON <jeanbaptiste.charron@outlook.fr> * Bump dependencies * Lint * Bump com.google.dagget.hilt to 2.46.1 * Migrate to non-transitiveRClass * Bump androidx.room to 2.5.1 * Api 33 (#277) * Bump coroutines to 1.7.1 * Fix apr repo test * Cleanup of opt ins to experimental test coroutines * Clean up * Remove unsused extension fun * Remove opt ins * Expand test coverage * Add an additional test for retrieving a list of trackers * Remove opt ins * Improve format * Clean up * Remove unused test rules * Remove opt ins * Clean Up * Remove opt ins * Remove unused vals * Bump kotlinx:kotlinx-coroutines-test to 1.7.1 * Bump com.google.android.material to 1.9.0 Fixes broken sub fragments. * Update Compile options for kotlin * Bump gradle to 8.0.1 * Update operators * Remove redundant test * Bump JDK version (#280) * Fix deprecations (#281) * Implement extension fun for getting pkgs * Implement extension fun for app source * Move getInstalledPackagesList to common Implement getSource in common * Import extension funs in PackageRepository * Adapt PackageRepositoryTest * cleanup * use extension fun * fix deprecations * Linting * remove unnecessary comment * Fix crash when device has not mail app or app store * Api 33 (#291) * Set white chip icon color in dark mode * Use themed text and icon colors in chip @color/m3_chip_text_color was marked private in material 1.9.0. So a default color was used, which broke the style of the chip. Add light/dark theme specific colors for chip text color and icon. --------- Co-authored-by: PatDyn <37243484+PatDyn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should somewhat mitigate or even solve Issue #260 and #264.
It may even improve first startup performance a little bit.
What changed: