Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::unique_ptr rather than raw pointer #3179

Merged
merged 7 commits into from
Feb 20, 2025
+49 −75
Merged

Use std::unique_ptr rather than raw pointer #3179

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50052da
Use unique_ptr rather than raw pointer.
kevinbackhouse Feb 19, 2025
3be906d
Code review suggestions from @neheb.
kevinbackhouse Feb 19, 2025
754f98b
Code review suggestions from @neheb.
kevinbackhouse Feb 20, 2025
1688923
clang-format
kevinbackhouse Feb 20, 2025
8331257
Use emplace_back()
kevinbackhouse Feb 20, 2025
ff65bbb
Move TiffIfdMakernote destructor to .cpp file to fix a build error
kevinbackhouse Feb 20, 2025
52925b8
Code review suggestion from @neheb.
kevinbackhouse Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/tiffcomposite_int.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ TiffIfdMakernote::TiffIfdMakernote(uint16_t tag, IfdId group, IfdId mnGroup, std
TiffComponent(tag, group), pHeader_(std::move(pHeader)), ifd_(tag, mnGroup, hasNext) {
}

TiffIfdMakernote::~TiffIfdMakernote() {
}

TiffBinaryArray::TiffBinaryArray(uint16_t tag, IfdId group, const ArrayCfg& arrayCfg, const ArrayDef* arrayDef,
size_t defSize) :
TiffEntryBase(tag, group, arrayCfg.elTiffType_), arrayCfg_(&arrayCfg), arrayDef_(arrayDef), defSize_(defSize) {
Expand Down
2 changes: 1 addition & 1 deletion src/tiffcomposite_int.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@ class TiffIfdMakernote : public TiffComponent {
//! Default constructor
TiffIfdMakernote(uint16_t tag, IfdId group, IfdId mnGroup, std::unique_ptr<MnHeader> pHeader, bool hasNext = true);
//! Virtual destructor
~TiffIfdMakernote() override = default;
~TiffIfdMakernote() override;
//@}

/*!
Expand Down
Loading